From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751945AbdCCRus (ORCPT ); Fri, 3 Mar 2017 12:50:48 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:44387 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbdCCRuq (ORCPT ); Fri, 3 Mar 2017 12:50:46 -0500 From: Alexey Brodkin To: "Liviu.Dudau@arm.com" CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "daniel@ffwll.ch" , "airlied@linux.ie" , "robh+dt@kernel.org" , "linux-snps-arc@lists.infradead.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property Thread-Topic: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property Thread-Index: AQHSlDGTEmuTvpdNt0S/hqvgRgNDbqGDPUSAgAAWQwA= Date: Fri, 3 Mar 2017 17:48:19 +0000 Message-ID: <1488563298.2940.33.camel@synopsys.com> References: <1488554364-25579-1-git-send-email-abrodkin@synopsys.com> <20170303162837.GO917@e110455-lin.cambridge.arm.com> In-Reply-To: <20170303162837.GO917@e110455-lin.cambridge.arm.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.45] Content-Type: text/plain; charset="utf-8" Content-ID: <1813302EC06FDE46A08990C92D967D08@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v23HpKfp013649 Hi Liviu, On Fri, 2017-03-03 at 16:28 +0000, Liviu Dudau wrote: > On Fri, Mar 03, 2017 at 06:19:24PM +0300, Alexey Brodkin wrote: > > > > - /* find the encoder node and initialize it */ > > - encoder_node = of_parse_phandle(drm->dev->of_node, "encoder-slave", 0); > > - if (encoder_node) { > > - ret = arcpgu_drm_hdmi_init(drm, encoder_node); > > - of_node_put(encoder_node); > > + /* There is only one output port inside each device, find it */ > > + port = of_graph_get_next_endpoint(pdev->dev.of_node, NULL); > > + > > + if (port) { > > + if (of_device_is_available(port)) > > + encoder = of_graph_get_remote_port_parent(port); > > + of_node_put(port); > > + } > > You must've been looking at some old version. Current version in -next uses > of_graph_get_remote_node() to replace all those lines you have added (see Rob > Herring's series to introduce of_graph_get_remote_node() function) Hm, I'm not on Linus' master tree [1] and so I thought I was quite up to date :) Still I made a check of linux-next and don't see any changes in "drivers/gpu/drm/arm" compared to Linus' tree. [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/arm?id=e4563f6ba71792c77aeccb2092cc23149b44e642 [2] http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/gpu/drm/arm?id=e4563f6ba71792c77aeccb2092cc23149b44e642 Could you please clarify which exact tree did you mean? Anyways I just tried to rebase my patch on top of linux-next tree and now video output is broken for me - I only see some garbage on top of the screen so I'll need to investigate it first before moving forward with stuff you proposed :) -Alexey