From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com,
outreachy-kernel@googlegroups.com, kirk@reisers.ca,
samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org,
speakup@linux-speakup.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH 6/6] staging: speakup: fixes braces {} should be used on all arms of this statement
Date: Fri, 03 Mar 2017 12:16:34 -0800 [thread overview]
Message-ID: <1488572194.2179.36.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1703031940410.2133@hadrien>
On Fri, 2017-03-03 at 19:40 +0100, Julia Lawall wrote:
> On Sat, 4 Mar 2017, Arushi Singhal wrote:
> > This patch fixes the checks reported by checkpatch.pl
> > for braces {} should be used on all arms of this statement.
> >
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> > ---
> > drivers/staging/speakup/main.c | 29 +++++++++++++++++++----------
> > 1 file changed, 19 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> > index 7915e75664f4..6179e0aafa25 100644
> > --- a/drivers/staging/speakup/main.c
> > +++ b/drivers/staging/speakup/main.c
> > @@ -640,8 +640,9 @@ static void say_prev_word(struct vc_data *vc)
> > break;
> > spk_y--;
> > spk_x = vc->vc_cols - 1;
> > - } else
> > + } else{
>
> else needs a space after it.
And if you had scanned this suggested patch with
checkpatch, you would have known that.
prev parent reply other threads:[~2017-03-03 20:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 18:37 [PATCH 0/6] multiple checkpatch issues Arushi Singhal
2017-03-03 18:37 ` [PATCH 1/6] staging: speakup: Add blank line after function/struct/union/enum declarations Arushi Singhal
2017-03-03 18:37 ` [PATCH 2/6] staging: speakup: simple_strtoul is replaced with kstrtoul Arushi Singhal
2017-03-03 18:45 ` [Outreachy kernel] " Julia Lawall
2017-03-03 18:37 ` [PATCH 3/6] staging: speakup: Logical continuations should be on the previous line Arushi Singhal
2017-03-03 18:37 ` [PATCH 4/6] staging: speakup: Blank lines removed after an open brace '{' Arushi Singhal
2017-03-03 18:37 ` [PATCH 5/6] staging: speakup: Avoid multiple assignments on same line Arushi Singhal
2017-03-03 18:42 ` [Outreachy kernel] " Julia Lawall
2017-03-03 18:37 ` [PATCH 6/6] staging: speakup: fixes braces {} should be used on all arms of this statement Arushi Singhal
2017-03-03 18:40 ` [Outreachy kernel] " Julia Lawall
2017-03-03 20:16 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488572194.2179.36.camel@perches.com \
--to=joe@perches.com \
--cc=arushisinghal19971997@gmail.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox