From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752724AbdCGHYj (ORCPT ); Tue, 7 Mar 2017 02:24:39 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:46121 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751443AbdCGHYb (ORCPT ); Tue, 7 Mar 2017 02:24:31 -0500 From: Chunfeng Yun To: Mathias Nyman CC: Matthias Brugger , Felipe Balbi , Chunfeng Yun , , , , , Greg Kroah-Hartman Subject: [PATCH 2/2] usb: xhci-mtk: fix checkpatch warning and erorr Date: Tue, 7 Mar 2017 14:57:21 +0800 Message-ID: <1488869841-9959-2-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1488869841-9959-1-git-send-email-chunfeng.yun@mediatek.com> References: <1488869841-9959-1-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org there are two warnings and a erorr when checked by checkpatch.pl as following: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses Signed-off-by: Chunfeng Yun --- drivers/usb/host/xhci-mtk.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c index 9636884..22c94fe 100644 --- a/drivers/usb/host/xhci-mtk.c +++ b/drivers/usb/host/xhci-mtk.c @@ -287,9 +287,9 @@ static void usb_wakeup_ip_sleep_dis(struct xhci_hcd_mtk *mtk) } /* -* for line-state wakeup mode, phy's power should not power-down -* and only support cable plug in/out -*/ + * for line-state wakeup mode, phy's power should not power-down + * and only support cable plug in/out + */ static void usb_wakeup_line_state_en(struct xhci_hcd_mtk *mtk) { u32 tmp; @@ -350,10 +350,10 @@ static int usb_wakeup_of_property_parse(struct xhci_hcd_mtk *mtk, struct device *dev = mtk->dev; /* - * wakeup function is optional, so it is not an error if this property - * does not exist, and in such case, no need to get relative - * properties anymore. - */ + * wakeup function is optional, so it is not an error if this property + * does not exist, and in such case, no need to get relative + * properties anymore. + */ of_property_read_u32(dn, "mediatek,wakeup-src", &mtk->wakeup_src); if (!mtk->wakeup_src) return 0; @@ -796,7 +796,7 @@ static int __maybe_unused xhci_mtk_resume(struct device *dev) static const struct dev_pm_ops xhci_mtk_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(xhci_mtk_suspend, xhci_mtk_resume) }; -#define DEV_PM_OPS IS_ENABLED(CONFIG_PM) ? &xhci_mtk_pm_ops : NULL +#define DEV_PM_OPS (IS_ENABLED(CONFIG_PM) ? &xhci_mtk_pm_ops : NULL) #ifdef CONFIG_OF static const struct of_device_id mtk_xhci_of_match[] = { -- 1.7.9.5