From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH 2/3] ASoC: dio2125: add dio2125 amp driver
Date: Tue, 07 Mar 2017 14:13:20 +0100 [thread overview]
Message-ID: <1488892400.2420.26.camel@baylibre.com> (raw)
In-Reply-To: <20170307123653.jg7jqe4sft2pqycc@sirena.org.uk>
On Tue, 2017-03-07 at 13:36 +0100, Mark Brown wrote:
> On Mon, Mar 06, 2017 at 06:44:50PM +0100, Jerome Brunet wrote:
>
> > + gpiod_set_value(priv->gpiod_enable, val);
>
> You should use gpiod_set_value_cansleep() so that the driver can work
> with all GPIOs unless there's a specific need to have GPIOs you can
> control in interrupt (which should be the case for anything you're
> using
> for DAPM control).
Indeed, Thanks for pointing this out.
I have question regarding this DAPM control.
Here, I put the control in DAPM so it can help with the pop noise
reduction, but I think it would be nice if the user could force the
mute if he wants to.
Would it be OK to add a user control and some logic so the output is
enabled only if DAPM and the user agree it should ?
>
> Please submit an incremental patch fixing this.
Done
next prev parent reply other threads:[~2017-03-07 14:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 17:44 [PATCH 0/3] ASoC: add dio2125 amplifier support Jerome Brunet
2017-03-06 17:44 ` [PATCH 1/3] dt-bindings: add vendor prefix for Dioo Jerome Brunet
2017-03-06 17:44 ` [PATCH 2/3] ASoC: dio2125: add dio2125 amp driver Jerome Brunet
2017-03-07 12:36 ` Mark Brown
2017-03-07 13:13 ` Jerome Brunet [this message]
2017-03-07 13:47 ` [alsa-devel] " Lars-Peter Clausen
2017-03-07 13:55 ` Mark Brown
2017-03-07 12:57 ` Applied "ASoC: dio2125: add dio2125 amp driver" to the asoc tree Mark Brown
2017-03-06 17:44 ` [PATCH 3/3] ASoC: dio2125: add dt-bindings Jerome Brunet
2017-03-07 12:57 ` Applied "ASoC: dio2125: add dt-bindings" to the asoc tree Mark Brown
2017-03-07 16:26 ` [PATCH 0/3] ASoC: add dio2125 amplifier support Jerome Brunet
2017-03-08 10:00 ` Mark Brown
2017-03-15 17:07 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488892400.2420.26.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=khilman@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox