From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754874AbdCGOYI (ORCPT ); Tue, 7 Mar 2017 09:24:08 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:32982 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755313AbdCGOXJ (ORCPT ); Tue, 7 Mar 2017 09:23:09 -0500 Message-ID: <1488892400.2420.26.camel@baylibre.com> Subject: Re: [PATCH 2/3] ASoC: dio2125: add dio2125 amp driver From: Jerome Brunet To: Mark Brown Cc: Liam Girdwood , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Kevin Hilman , Neil Armstrong Date: Tue, 07 Mar 2017 14:13:20 +0100 In-Reply-To: <20170307123653.jg7jqe4sft2pqycc@sirena.org.uk> References: <20170306174451.24406-1-jbrunet@baylibre.com> <20170306174451.24406-3-jbrunet@baylibre.com> <20170307123653.jg7jqe4sft2pqycc@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.5 (3.22.5-1.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-03-07 at 13:36 +0100, Mark Brown wrote: > On Mon, Mar 06, 2017 at 06:44:50PM +0100, Jerome Brunet wrote: > > > + gpiod_set_value(priv->gpiod_enable, val); > > You should use gpiod_set_value_cansleep() so that the driver can work > with all GPIOs unless there's a specific need to have GPIOs you can > control in interrupt (which should be the case for anything you're > using > for DAPM control). Indeed, Thanks for pointing this out. I have question regarding this DAPM control. Here, I put the control in DAPM so it can help with the pop noise reduction, but I think it would be nice if the user could force the mute if he wants to. Would it be OK to add a user control and some logic so the output is enabled only if DAPM and the user agree it should ? > > Please submit an incremental patch fixing this. Done