From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932823AbdCGQ1V (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Mar 2017 11:27:21 -0500
Received: from mail-wm0-f42.google.com ([74.125.82.42]:35586 "EHLO
        mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755665AbdCGQ1I (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Mar 2017 11:27:08 -0500
Message-ID: <1488903977.28627.4.camel@baylibre.com>
Subject: Re: [PATCH 0/3] ASoC: add dio2125 amplifier support
From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
        Neil Armstrong <narmstrong@baylibre.com>
Date: Tue, 07 Mar 2017 17:26:17 +0100
In-Reply-To: <20170306174451.24406-1-jbrunet@baylibre.com>
References: <20170306174451.24406-1-jbrunet@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.5 (3.22.5-1.fc25) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mark,

In this series, you applied patch 2 and 3 but not patch 1.
(so the dioo prefix is used but not documented)

Is it on purpose ?
The patch does not have the "ASoC" prefix, this maybe why it was
missed. Since, the file does no belong to alsa, I wasn't sure whether
to put the prefix or not.

Regards

Jerome

On Mon, 2017-03-06 at 18:44 +0100, Jerome Brunet wrote:
> This patchset adds the support for the dio2125 from Dioo
> microcircuits.
> The dio2125 is audio driver with adjustable gain. The EN pad allows
> to
> enable or disable the outputs of the driver.
> 
> The link to the datasheet is not provided as part of the commit. It
> is not
> provided the manufacturer and it is doubtful it will still be
> available a
> few years from now. Still provided here in case anyone is interested
> [0].
> 
> This patchset has been tested on Amlogic's meson-gxbb-p200 board.
> 
> [0]: http://www.winine.com/Line%E9%9F%B3/DIO2125XM10%20V1.0.pdf
> 
> Jerome Brunet (3):
>   dt-bindings: add vendor prefix for Dioo
>   ASoC: dio2125: add dio2125 amp driver
>   ASoC: dio2125: add dt-bindings
> 
>  .../devicetree/bindings/sound/dioo,dio2125.txt     |  12 +++
>  .../devicetree/bindings/vendor-prefixes.txt        |   1 +
>  sound/soc/codecs/Kconfig                           |   5 +
>  sound/soc/codecs/Makefile                          |   2 +
>  sound/soc/codecs/dio2125.c                         | 120
> +++++++++++++++++++++
>  5 files changed, 140 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/sound/dioo,dio2125.txt
>  create mode 100644 sound/soc/codecs/dio2125.c
>