public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-efi@vger.kernel.org, thgarnie@google.com,
	keescook@chromium.org, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, x86@kernel.org, akpm@linux-foundation.org,
	dyoung@redhat.com, Baoquan He <bhe@redhat.com>
Subject: [PATCH 2/2] x86/mm/KASLR: Correct the upper boundary of KALSR mm regions if adjacent to EFI
Date: Wed,  8 Mar 2017 15:47:38 +0800	[thread overview]
Message-ID: <1488959258-4731-2-git-send-email-bhe@redhat.com> (raw)
In-Reply-To: <1488959258-4731-1-git-send-email-bhe@redhat.com>

EFI allocates runtime services regions top-down, starting from EFI_VA_START
to EFI_VA_END. So EFI_VA_START is bigger than EFI_VA_END and is the end of
EFI region. The upper boundary of memory regions randomized by KASLR should
be EFI_VA_END if it's adjacent to EFI region, but not EFI_VA_START.

Correct it in this patch.

Signed-off-by: Baoquan He <bhe@redhat.com>
---
 arch/x86/mm/kaslr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/kaslr.c b/arch/x86/mm/kaslr.c
index 887e571..aed2064 100644
--- a/arch/x86/mm/kaslr.c
+++ b/arch/x86/mm/kaslr.c
@@ -48,7 +48,7 @@ static const unsigned long vaddr_start = __PAGE_OFFSET_BASE;
 #if defined(CONFIG_X86_ESPFIX64)
 static const unsigned long vaddr_end = ESPFIX_BASE_ADDR;
 #elif defined(CONFIG_EFI)
-static const unsigned long vaddr_end = EFI_VA_START;
+static const unsigned long vaddr_end = EFI_VA_END;
 #else
 static const unsigned long vaddr_end = __START_KERNEL_map;
 #endif
@@ -105,7 +105,7 @@ void __init kernel_randomize_memory(void)
 	 */
 	BUILD_BUG_ON(vaddr_start >= vaddr_end);
 	BUILD_BUG_ON(IS_ENABLED(CONFIG_X86_ESPFIX64) &&
-		     vaddr_end >= EFI_VA_START);
+		     vaddr_end >= EFI_VA_END);
 	BUILD_BUG_ON((IS_ENABLED(CONFIG_X86_ESPFIX64) ||
 		      IS_ENABLED(CONFIG_EFI)) &&
 		     vaddr_end >= __START_KERNEL_map);
-- 
2.5.5

  reply	other threads:[~2017-03-08  7:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08  7:47 [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Baoquan He
2017-03-08  7:47 ` Baoquan He [this message]
2017-03-08  8:18   ` [PATCH 2/2] x86/mm/KASLR: Correct the upper boundary of KALSR mm regions if adjacent to EFI Dave Young
2017-03-08  8:35     ` Bhupesh Sharma
2017-03-08 15:32       ` Thomas Garnier
2017-03-15  6:13   ` Baoquan He
2017-03-15  6:31     ` Baoquan He
2017-03-08  8:18 ` [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Dave Young
2017-03-08  8:45   ` Baoquan He
2017-03-08  8:54     ` Borislav Petkov
2017-03-08  9:08       ` Baoquan He
2017-03-09  1:38     ` Dave Young
2017-03-08  9:00   ` Bhupesh Sharma
2017-03-08  9:09     ` Baoquan He
2017-03-08  9:35       ` Borislav Petkov
2017-03-08 10:17         ` Baoquan He
2017-03-08 10:50           ` Borislav Petkov
2017-03-09  0:48             ` Dave Young
2017-03-08 20:05         ` Bhupesh Sharma
2017-03-08  9:45     ` Baoquan He
2017-03-08 10:45 ` [PATCH v2 1/2] x86/efi/64: Clean up code comment about efi region Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488959258-4731-2-git-send-email-bhe@redhat.com \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=thgarnie@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox