* Re: [PATCH] Minor coding guideline Fix in lusture module
2017-03-09 12:22 [PATCH] Minor coding guideline Fix in lusture module Pushkar Jambhlekar
@ 2017-03-09 13:15 ` Greg Kroah-Hartman
2017-03-10 5:25 ` Dilger, Andreas
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-09 13:15 UTC (permalink / raw)
To: Pushkar Jambhlekar
Cc: Oleg Drokin, Andreas Dilger, James Simmons, John L. Hammond,
Jinshan Xiong, Fan Yong, lustre-devel, devel, linux-kernel
On Thu, Mar 09, 2017 at 05:52:07PM +0530, Pushkar Jambhlekar wrote:
> Replacing 'unsigned' with 'unsigned int' in vvp_pgcache_id.
> Checkpath.pl passed.
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/vvp_dev.c b/drivers/staging/lustre/lustre/llite/vvp_dev.c
> index 12c129f7e..8d78755 100644
> --- a/drivers/staging/lustre/lustre/llite/vvp_dev.c
> +++ b/drivers/staging/lustre/lustre/llite/vvp_dev.c
> @@ -381,11 +381,10 @@ int cl_sb_fini(struct super_block *sb)
> #define PGC_DEPTH_SHIFT (32)
>
> struct vvp_pgcache_id {
> - unsigned vpi_bucket;
> - unsigned vpi_depth;
> - uint32_t vpi_index;
> -
> - unsigned vpi_curdep;
> + unsigned int vpi_bucket;
> + unsigned int vpi_depth;
> + uint32_t vpi_index;
> + unsigned int vpi_curdep;
> struct lu_object_header *vpi_obj;
> };
>
> --
> 2.7.4
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what is needed in order to
properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what a proper Subject: line should
look like.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Minor coding guideline Fix in lusture module
2017-03-09 12:22 [PATCH] Minor coding guideline Fix in lusture module Pushkar Jambhlekar
2017-03-09 13:15 ` Greg Kroah-Hartman
@ 2017-03-10 5:25 ` Dilger, Andreas
1 sibling, 0 replies; 3+ messages in thread
From: Dilger, Andreas @ 2017-03-10 5:25 UTC (permalink / raw)
To: Pushkar Jambhlekar
Cc: Drokin, Oleg, James Simmons, Greg Kroah-Hartman, Hammond, John,
Xiong, Jinshan, lustre-devel, devel@driverdev.osuosl.org, LKML
On Mar 9, 2017, at 05:22, Pushkar Jambhlekar <pushkar.iit@gmail.com> wrote:
> Subject: Minor coding guideline Fix in lusture module
I suspect the patchbot is unhappy with the subject line not containing anything
useful, and not containing the subsystem name. Something like:
staging/lustre/llite: replace "unsigned" with "unsigned int"
> Replacing 'unsigned' with 'unsigned int' in vvp_pgcache_id.
Remove double space, and reference function names like vvp_pgcache_id().
> Checkpath.pl passed.
"checkpatch.pl"
Cheers, Andreas
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/vvp_dev.c b/drivers/staging/lustre/lustre/llite/vvp_dev.c
> index 12c129f7e..8d78755 100644
> --- a/drivers/staging/lustre/lustre/llite/vvp_dev.c
> +++ b/drivers/staging/lustre/lustre/llite/vvp_dev.c
> @@ -381,11 +381,10 @@ int cl_sb_fini(struct super_block *sb)
> #define PGC_DEPTH_SHIFT (32)
>
> struct vvp_pgcache_id {
> - unsigned vpi_bucket;
> - unsigned vpi_depth;
> - uint32_t vpi_index;
> -
> - unsigned vpi_curdep;
> + unsigned int vpi_bucket;
> + unsigned int vpi_depth;
> + uint32_t vpi_index;
> + unsigned int vpi_curdep;
> struct lu_object_header *vpi_obj;
> };
>
> --
> 2.7.4
>
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread