public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Tobin C. Harding" <me@tobin.cc>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static
Date: Thu, 09 Mar 2017 19:22:46 +0100	[thread overview]
Message-ID: <1489083766.5228.10.camel@gmx.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1703091849400.3521@nanos>

On Thu, 2017-03-09 at 18:50 +0100, Thomas Gleixner wrote:
> On Thu, 9 Mar 2017, Mike Galbraith wrote:
> 
> > Greetings,
> > 
> > I bisected kdump breakage to $subject, and verified the identified
> > culprit via revert.  Seems kexec needs those variables as they were.
> 
> Yuck. That does not make any sense at all. I'll try to figure out why.

Dunno, but I did find this.

git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
./kexec/arch/x86_64/kexec-x86_64.c:     elf_rel_set_symbol(&info->rhdr, "backup_src_start",
./kexec/arch/x86_64/kexec-x86_64.c:     elf_rel_set_symbol(&info->rhdr, "backup_src_size",
./kexec/arch/x86_64/kexec-x86_64.c:             elf_rel_set_symbol(&info->rhdr, "backup_start",

  reply	other threads:[~2017-03-09 18:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-09 14:04 [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static Mike Galbraith
2017-03-09 17:50 ` Thomas Gleixner
2017-03-09 18:22   ` Mike Galbraith [this message]
2017-03-09 19:11     ` Thomas Gleixner
2017-03-09 20:17       ` Tobin C. Harding
2017-03-09 20:32       ` Borislav Petkov
2017-03-09 20:42         ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489083766.5228.10.camel@gmx.de \
    --to=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@tobin.cc \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox