* [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static
@ 2017-03-09 14:04 Mike Galbraith
2017-03-09 17:50 ` Thomas Gleixner
0 siblings, 1 reply; 7+ messages in thread
From: Mike Galbraith @ 2017-03-09 14:04 UTC (permalink / raw)
To: Tobin C. Harding; +Cc: Thomas Gleixner, LKML
Greetings,
I bisected kdump breakage to $subject, and verified the identified
culprit via revert. Seems kexec needs those variables as they were.
-Mike
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static
2017-03-09 14:04 [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static Mike Galbraith
@ 2017-03-09 17:50 ` Thomas Gleixner
2017-03-09 18:22 ` Mike Galbraith
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Gleixner @ 2017-03-09 17:50 UTC (permalink / raw)
To: Mike Galbraith; +Cc: Tobin C. Harding, LKML
On Thu, 9 Mar 2017, Mike Galbraith wrote:
> Greetings,
>
> I bisected kdump breakage to $subject, and verified the identified
> culprit via revert. Seems kexec needs those variables as they were.
Yuck. That does not make any sense at all. I'll try to figure out why.
Thanks,
tglx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static
2017-03-09 17:50 ` Thomas Gleixner
@ 2017-03-09 18:22 ` Mike Galbraith
2017-03-09 19:11 ` Thomas Gleixner
0 siblings, 1 reply; 7+ messages in thread
From: Mike Galbraith @ 2017-03-09 18:22 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Tobin C. Harding, LKML
On Thu, 2017-03-09 at 18:50 +0100, Thomas Gleixner wrote:
> On Thu, 9 Mar 2017, Mike Galbraith wrote:
>
> > Greetings,
> >
> > I bisected kdump breakage to $subject, and verified the identified
> > culprit via revert. Seems kexec needs those variables as they were.
>
> Yuck. That does not make any sense at all. I'll try to figure out why.
Dunno, but I did find this.
git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start",
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size",
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start",
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static
2017-03-09 18:22 ` Mike Galbraith
@ 2017-03-09 19:11 ` Thomas Gleixner
2017-03-09 20:17 ` Tobin C. Harding
2017-03-09 20:32 ` Borislav Petkov
0 siblings, 2 replies; 7+ messages in thread
From: Thomas Gleixner @ 2017-03-09 19:11 UTC (permalink / raw)
To: Mike Galbraith; +Cc: Tobin C. Harding, LKML
On Thu, 9 Mar 2017, Mike Galbraith wrote:
> On Thu, 2017-03-09 at 18:50 +0100, Thomas Gleixner wrote:
> > On Thu, 9 Mar 2017, Mike Galbraith wrote:
> >
> > > Greetings,
> > >
> > > I bisected kdump breakage to $subject, and verified the identified
> > > culprit via revert. Seems kexec needs those variables as they were.
> >
> > Yuck. That does not make any sense at all. I'll try to figure out why.
>
> Dunno, but I did find this.
>
> git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
> ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start",
> ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size",
> ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start",
Came so far as well. Lovely undocumented dependencies.....
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static
2017-03-09 19:11 ` Thomas Gleixner
@ 2017-03-09 20:17 ` Tobin C. Harding
2017-03-09 20:32 ` Borislav Petkov
1 sibling, 0 replies; 7+ messages in thread
From: Tobin C. Harding @ 2017-03-09 20:17 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Mike Galbraith, LKML
On Thu, Mar 09, 2017 at 08:11:03PM +0100, Thomas Gleixner wrote:
> On Thu, 9 Mar 2017, Mike Galbraith wrote:
> > On Thu, 2017-03-09 at 18:50 +0100, Thomas Gleixner wrote:
> > > On Thu, 9 Mar 2017, Mike Galbraith wrote:
> > >
> > > > Greetings,
> > > >
> > > > I bisected kdump breakage to $subject, and verified the identified
> > > > culprit via revert. Seems kexec needs those variables as they were.
> > >
> > > Yuck. That does not make any sense at all. I'll try to figure out why.
> >
> > Dunno, but I did find this.
> >
> > git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
> > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start",
> > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size",
> > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start",
>
> Came so far as well. Lovely undocumented dependencies.....
I'm out of my depth on this one. If there is some task I can do to
save you time or effort, point me at it.
thanks,
Tobin.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static
2017-03-09 19:11 ` Thomas Gleixner
2017-03-09 20:17 ` Tobin C. Harding
@ 2017-03-09 20:32 ` Borislav Petkov
2017-03-09 20:42 ` Thomas Gleixner
1 sibling, 1 reply; 7+ messages in thread
From: Borislav Petkov @ 2017-03-09 20:32 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Mike Galbraith, Tobin C. Harding, LKML
On Thu, Mar 09, 2017 at 08:11:03PM +0100, Thomas Gleixner wrote:
> > git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
> > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start",
> > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size",
> > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start",
>
> Came so far as well. Lovely undocumented dependencies.....
Maybe that'll help a little:
https://lkml.kernel.org/r/20170103153814.GC29807@redhat.com
And yap, that thing needs a bunch of text ontop saying sh*t and why it
is magical.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static
2017-03-09 20:32 ` Borislav Petkov
@ 2017-03-09 20:42 ` Thomas Gleixner
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Gleixner @ 2017-03-09 20:42 UTC (permalink / raw)
To: Borislav Petkov; +Cc: Mike Galbraith, Tobin C. Harding, LKML
On Thu, 9 Mar 2017, Borislav Petkov wrote:
> On Thu, Mar 09, 2017 at 08:11:03PM +0100, Thomas Gleixner wrote:
> > > git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
> > > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start",
> > > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size",
> > > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start",
> >
> > Came so far as well. Lovely undocumented dependencies.....
>
> Maybe that'll help a little:
>
> https://lkml.kernel.org/r/20170103153814.GC29807@redhat.com
>
> And yap, that thing needs a bunch of text ontop saying sh*t and why it
> is magical.
I know how to fix it, but I'll do that tomorrow with brain awake
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-03-09 20:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-09 14:04 [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static Mike Galbraith
2017-03-09 17:50 ` Thomas Gleixner
2017-03-09 18:22 ` Mike Galbraith
2017-03-09 19:11 ` Thomas Gleixner
2017-03-09 20:17 ` Tobin C. Harding
2017-03-09 20:32 ` Borislav Petkov
2017-03-09 20:42 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox