From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754220AbdCISXA (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Mar 2017 13:23:00 -0500
Received: from mout.gmx.net ([212.227.17.20]:55373 "EHLO mout.gmx.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750781AbdCISW7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Mar 2017 13:22:59 -0500
Message-ID: <1489083766.5228.10.camel@gmx.de>
Subject: Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and
 variables static
From: Mike Galbraith <efault@gmx.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Tobin C. Harding" <me@tobin.cc>, LKML <linux-kernel@vger.kernel.org>
Date: Thu, 09 Mar 2017 19:22:46 +0100
In-Reply-To: <alpine.DEB.2.20.1703091849400.3521@nanos>
References: <1489068254.4381.18.camel@gmx.de>
         <alpine.DEB.2.20.1703091849400.3521@nanos>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.16.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:xbfmWV2lh2z6M81wnbtIzkSMdM7SgPSOy+yunBZzVq5llqOJdhy
 0UKvkv/EdJJtdWrNlXkj/mEYHfufKcoTu6vwIBFm4eiSLvWGk8m/qIub7Mdp0xqTh8VyoTq
 0vqm5EgMAU7c1qSnBglxepuAmSCy7xBsGX3G+9IRYpFF7gw0qfeBKJPmEWQJpTn8j/CVviR
 ZuwCkY8Isrglu0jvOOr2w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:Dz91PfrUzro=:X6YLg7HoiiSet4HTvv6A8B
 m7/BWHacKx5FtpjGZrYyPkBwXo0mcxYyIx7ELiPsTdK9KtRK+8zS0wLdtPFZvO9v6XSLcoloQ
 dOlvjCJzzLqKgMLkd270173BGL9R609P+vVHu93DSpLnQiXAKnC1bUJEZaz4OSggLgL0ZKEbL
 C7LUOdqNzfILVxE0dmlqnanO/l6kh0rdkDIpUGHXzwRPoTYHvJhGAnExF9zwRpXmZT4ZTKGYj
 g2Mgp9pbbgSncu6A+VhS5kobyqzU2WXkPSgfzee21ovrqZEaMQtk1DMjtWHJuLC5j7d7nVsad
 PA3RiJo0dZekIvvSi7wjT/E8BbWeLF+FQb6xhUKJuIzaEjwLpL4vD2B7zMgev0k9YdmPf3HsY
 /6ILCXbLrSTlfuVOE9jFI2j0KGKvi8Bb4xnLHoIloriyB8yofS2uLvTUJMMwXFJB9EvB3defO
 KLNF+LnnWDip5jDRwf/c79kxJKx/puOU135sfXz1T4d3/Pnoblj+XkxxbF/s9pUKxaFiC4W6e
 PZfEs1YM9UWF7NTyUkRAmfJ9nC9ygcSWJ4RNXCt2vYOE2Y5EnIkw3XXjhLE6mQdq6y0VpQbSb
 hTLpBg7wxkUN20NXMVJVZnGT6VxfzC1IHqv6YzpQnXt6mML9/HLUJxr6p0LrG0yoWTCPJtcnY
 zgYcA3CzQuUdP9THrJFDToIRQnU4Op80oPwV7O5RJwBEntbeq07MT/ncMPEq+eu+vSdJkPBnz
 ywc1NoqwOaooAGkZS8vwHRU/ZjD5nZf2ZsuP/zarxLJAjjDQqopw3RNua5QdvMpIQQUR7adRh
 8j72Cva
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2017-03-09 at 18:50 +0100, Thomas Gleixner wrote:
> On Thu, 9 Mar 2017, Mike Galbraith wrote:
> 
> > Greetings,
> > 
> > I bisected kdump breakage to $subject, and verified the identified
> > culprit via revert.  Seems kexec needs those variables as they were.
> 
> Yuck. That does not make any sense at all. I'll try to figure out why.

Dunno, but I did find this.

git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
./kexec/arch/x86_64/kexec-x86_64.c:     elf_rel_set_symbol(&info->rhdr, "backup_src_start",
./kexec/arch/x86_64/kexec-x86_64.c:     elf_rel_set_symbol(&info->rhdr, "backup_src_size",
./kexec/arch/x86_64/kexec-x86_64.c:             elf_rel_set_symbol(&info->rhdr, "backup_start",