From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751008AbdCNM2T (ORCPT ); Tue, 14 Mar 2017 08:28:19 -0400 Received: from mga04.intel.com ([192.55.52.120]:47726 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbdCNM2R (ORCPT ); Tue, 14 Mar 2017 08:28:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,163,1486454400"; d="scan'208";a="1108283830" Message-ID: <1489494491.20145.238.camel@linux.intel.com> Subject: Re: [PATCH v1 3/4] platform/x86: surface3_button: Propagate error from gpiod_count() From: Andy Shevchenko To: Linus Walleij Cc: "linux-gpio@vger.kernel.org" , Dmitry Torokhov , Linux Input , Darren Hart , platform-driver-x86 , Benjamin Tissoires , "linux-kernel@vger.kernel.org" Date: Tue, 14 Mar 2017 14:28:11 +0200 In-Reply-To: References: <20170220161549.39490-1-andriy.shevchenko@linux.intel.com> <20170220161549.39490-4-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-03-14 at 10:46 +0100, Linus Walleij wrote: > On Mon, Feb 20, 2017 at 5:15 PM, Andy Shevchenko > wrote: > > > Since gpiod_count() does not return 0 anymore, we don't need to > > shadow > > its error code and would safely propagate to the user. > > > > While here, replace second parameter by NULL in order to prevent > > side > > effects on _DSD enabled firmware. > > > > Cc: Benjamin Tissoires > > Signed-off-by: Andy Shevchenko > > As I understand it Andy, you're more or less default-maintainer for > drivers/platform/x86 so I can just merge this patch into the > GPIO tree with the rest? Correct! -- Andy Shevchenko Intel Finland Oy