From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753205AbdCNP0C (ORCPT ); Tue, 14 Mar 2017 11:26:02 -0400 Received: from mga09.intel.com ([134.134.136.24]:31824 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbdCNPY7 (ORCPT ); Tue, 14 Mar 2017 11:24:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,164,1486454400"; d="scan'208";a="944175607" Message-ID: <1489504914.20145.247.camel@linux.intel.com> Subject: Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units From: Andy Shevchenko To: Lee Jones Cc: linux-kernel@vger.kernel.org Date: Tue, 14 Mar 2017 17:21:54 +0200 In-Reply-To: <20170314150234.z4omelqdwox5tts4@dell> References: <20170313190727.8069-1-andriy.shevchenko@linux.intel.com> <20170314150234.z4omelqdwox5tts4@dell> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-03-14 at 15:02 +0000, Lee Jones wrote: > On Mon, 13 Mar 2017, Andy Shevchenko wrote: > > > Crystal Cove and Whiskey Cove are two different PMICs which are > > installed on Intel Atom SoC based platforms. > > > > Moreover there are two independent drivers that by some reason are > > supposed (*) to get into one kernel module. > > > > Fix the mess by clarifying Kconfig option for Crystal Cove and split > > Whiskey Cove out of it. > > > > (*) It looks like the configuration was never ever tested. The line > > in > >     Makefile is actually wrong.   > >  config INTEL_SOC_PMIC > > - bool "Support for Intel Atom SoC PMIC" > > + bool "Support for Crystal Cove PMIC" > >   depends on GPIOLIB > >   depends on I2C=y > >   select MFD_CORE > >   select REGMAP_I2C > >   select REGMAP_IRQ > >   help > > -   Select this option to enable support for the PMIC device > > +   Select this option to enable support for Crystal Cove > > PMIC > >     on some Intel SoC systems. The PMIC provides ADC, GPIO, > >     thermal, charger and related power management functions > >     on these systems. > >   > > +config INTEL_SOC_PMIC_BXTWC > > + tristate > > + select MFD_CORE > > + select REGMAP_IRQ > > I think you need to make mention that this is Whiskey Cove? It's selectable option, so I don't know if it's a good idea to make it visible to the user. Or do you mean fill the help section only? -- Andy Shevchenko Intel Finland Oy