The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: <f.fainelli@gmail.com>, <davem@davemloft.net>
Cc: <andrew@lunn.ch>, <kyle.roeschley@ni.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Roger Quadros <rogerq@ti.com>
Subject: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for PHYs with interrupts
Date: Wed, 15 Mar 2017 15:51:27 +0200	[thread overview]
Message-ID: <1489585887-8683-1-git-send-email-rogerq@ti.com> (raw)

Since commit 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.")
phy_suspend() doesn't get called as part of phy_stop() for PHYs using
interrupts because the phy state machine is never triggered after a phy_stop().

Explicitly trigger the PHY state machine so that it can
see the new PHY state (HALTED) and suspend the PHY.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 drivers/net/phy/phy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 1be69d8..8fef03b 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -903,6 +903,7 @@ void phy_stop(struct phy_device *phydev)
 	 * of rtnl_lock(), but PHY_HALTED shall guarantee phy_change()
 	 * will not reenable interrupts.
 	 */
+	phy_trigger_machine(phydev, true);
 }
 EXPORT_SYMBOL(phy_stop);
 
-- 
2.7.4

             reply	other threads:[~2017-03-15 13:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15 13:51 Roger Quadros [this message]
2017-03-15 14:08 ` [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for PHYs with interrupts Andrew Lunn
2017-03-15 15:00   ` Roger Quadros
2017-03-15 15:49     ` Andrew Lunn
2017-03-16  7:46       ` Roger Quadros
2017-03-20 16:41         ` Florian Fainelli
2017-03-21 10:09           ` Roger Quadros
2017-03-21 16:00             ` Florian Fainelli
2017-03-20 16:42     ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489585887-8683-1-git-send-email-rogerq@ti.com \
    --to=rogerq@ti.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kyle.roeschley@ni.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox