Re: [scsi] scsi: ufs: don't check unsigned type for a negative value

James Bottomley
2017-03-15T17:26:48Z

On Mon, 2017-03-13 at 17:19 -0700, Subhash Jadavani wrote:
> On 2017-03-12 03:22, Tomas Winkler wrote:
> > Fix compilation warning
> >
> > drivers/scsi/ufs/ufshcd.c:7645:13: warning: comparison of unsigned
> > expression < 0 is always false [-Wtype-limits]
> > if ((value < UFS_PM_LVL_0) || (value >= UFS_PM_LVL_MAX))
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > ---
> > drivers/scsi/ufs/ufshcd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> > index 1359913bf840..e8c26e6e6237 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -7642,7 +7642,7 @@ static inline ssize_t
> > ufshcd_pm_lvl_store(struct
> > device *dev,
> > if (kstrtoul(buf, 0, &value))
> > return -EINVAL;
> >
> > - if ((value < UFS_PM_LVL_0) || (value >= UFS_PM_LVL_MAX))
> > + if (value >= UFS_PM_LVL_MAX)
> > return -EINVAL;
> >
> > spin_lock_irqsave(hba->host->host_lock, flags);
>
> LGTM.
> Reviewed-by: Subhash Jadavani <subhashj@codaurora.org>

Mis-spelling someone else's email can be cut and paste; mis-spelling
your own might be the early indications of an identity crisis.

We do cut and paste these tags, so getting your own name right for the
purposes of git history is useful.

James