From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751856AbdCPK3j (ORCPT ); Thu, 16 Mar 2017 06:29:39 -0400 Received: from smtprelay0096.hostedemail.com ([216.40.44.96]:47582 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751612AbdCPK3h (ORCPT ); Thu, 16 Mar 2017 06:29:37 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:305:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:7653:10004:10400:10848:11232:11658:11914:12214:12740:12760:12895:13069:13161:13229:13311:13357:13439:14096:14097:14659:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:5,LUA_SUMMARY:none X-HE-Tag: pull60_19019122e6124 X-Filterd-Recvd-Size: 1682 Message-ID: <1489660167.13953.1.camel@perches.com> Subject: Re: [PATCH 02/15] mm: page_alloc: align arguments to parenthesis From: Joe Perches To: Michal Hocko Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Date: Thu, 16 Mar 2017 03:29:27 -0700 In-Reply-To: <20170316080240.GB30501@dhcp22.suse.cz> References: <317ef9c31dba4c02905ad0222761b4337f081411.1489628477.git.joe@perches.com> <20170316080240.GB30501@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-03-16 at 09:02 +0100, Michal Hocko wrote: > On Wed 15-03-17 18:59:59, Joe Perches wrote: > > whitespace changes only - git diff -w shows no difference > > what is the point of this whitespace noise? Does it help readability? Yes. Consistency helps. > To be honest I do not think so. Opinions always vary. > Such a patch would make sense only if it > was a part of a larger series where other patches would actually do > something useful. Do please read the 0/n introduction to this series. And do remember to always strip the useless stuff you unnecessarily quoted too. 66kb in this case. There was a separate patch series 0/3 that actually did the more useful stuff. This patch series was purposely separated.