linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <guohanjun@huawei.com>, Kefeng Wang <wangkefeng.wang@huawei.com>,
	"Jiri Olsa" <jolsa@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Wang Nan <wangnan0@huawei.com>
Subject: [PATCH v2] perf probe: Return errno when does not hit any event
Date: Fri, 17 Mar 2017 16:16:32 +0800	[thread overview]
Message-ID: <1489738592-61011-1-git-send-email-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20170317105713.a4b1564a1fa2df5c9e340d5a@kernel.org>

On old perf, when using perf probe -d to delete an inexistent event,
it return errno, eg,

-bash-4.3# perf probe -d xxx  || echo $?
Info: Event "*:xxx" does not exist.
  Error: Failed to delete events.
255

But now perf_del_probe_events() will always set ret = 0, different
from previous del_perf_probe_events(). After this, it return errno
again, eg,

-bash-4.3# ./perf probe -d xxx  || echo $?
"xxx" does not hit any event.
  Error: Failed to delete events.
254

And it is more appropriate to return -ENOENT instead of -EPERM.

Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>

Fixes: dddc7ee32fa1 ("perf probe: Fix an error when deleting probes successfully")
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---

v1->v2:
- Using pr_wanring to show warning infos and drop inappropriate comment
  suggested by Masami Hiramatsu.

 tools/perf/builtin-probe.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index 1fcebc3..51cdc23 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -442,9 +442,9 @@ static int perf_del_probe_events(struct strfilter *filter)
 	}
 
 	if (ret == -ENOENT && ret2 == -ENOENT)
-		pr_debug("\"%s\" does not hit any event.\n", str);
-		/* Note that this is silently ignored */
-	ret = 0;
+		pr_warning("\"%s\" does not hit any event.\n", str);
+	else
+		ret = 0;
 
 error:
 	if (kfd >= 0)
-- 
1.7.12.4

  reply	other threads:[~2017-03-17  8:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-06  9:34 [PATCH] perf probe: Return errno when does not hit any event Kefeng Wang
2017-03-07  7:33 ` Kefeng Wang
2017-03-14 13:19   ` Kefeng Wang
2017-03-14 13:30     ` Arnaldo Carvalho de Melo
2017-03-16  9:39       ` Masami Hiramatsu
2017-03-16 12:07         ` Kefeng Wang
2017-03-17  1:57           ` Masami Hiramatsu
2017-03-17  8:16             ` Kefeng Wang [this message]
2017-03-17 23:23               ` [PATCH v2] " Masami Hiramatsu
2017-03-21 13:46                 ` Arnaldo Carvalho de Melo
2017-03-24 18:43               ` [tip:perf/core] perf probe: Return errno when not hitting " tip-bot for Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489738592-61011-1-git-send-email-wangkefeng.wang@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=acme@kernel.org \
    --cc=guohanjun@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=peterz@infradead.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).