From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760163AbdCVPTC (ORCPT ); Wed, 22 Mar 2017 11:19:02 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:46031 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbdCVPSx (ORCPT ); Wed, 22 Mar 2017 11:18:53 -0400 From: Lionel Debieve To: , CC: , , , Lionel Debieve Subject: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic Date: Wed, 22 Mar 2017 16:18:43 +0100 Message-ID: <1490195923-9560-1-git-send-email-lionel.debieve@st.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG5NODE1.st.com (10.75.127.13) To SFHDAG7NODE2.st.com (10.75.127.20) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-22_12:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use raw_spin_lock in enable/disable channel as it comes from interrupt context. BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:995 in_atomic(): 1, irqs_disabled(): 128, pid: 307, name: pulseaudio Preemption disabled at: [] __handle_domain_irq+0x4c/0xec CPU: 0 PID: 307 Comm: pulseaudio Hardware name: STi SoC with Flattened Device Tree [] (unwind_backtrace) [] (show_stack) [] (dump_stack) [] (___might_sleep) [] (rt_spin_lock) [] (sti_mbox_disable_channel) [] (sti_mbox_irq_handler) [] (__handle_irq_event_percpu) [] (handle_irq_event_percpu) [] (handle_irq_event) [] (handle_fasteoi_irq) [] (generic_handle_irq) [] (__handle_domain_irq) [] (gic_handle_irq) Signed-off-by: Lionel Debieve --- drivers/mailbox/mailbox-sti.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mailbox/mailbox-sti.c b/drivers/mailbox/mailbox-sti.c index 41bcd33..f9674ca 100644 --- a/drivers/mailbox/mailbox-sti.c +++ b/drivers/mailbox/mailbox-sti.c @@ -60,7 +60,7 @@ struct sti_mbox_device { void __iomem *base; const char *name; u32 enabled[STI_MBOX_INST_MAX]; - spinlock_t lock; + raw_spinlock_t lock; }; /** @@ -129,10 +129,10 @@ static void sti_mbox_enable_channel(struct mbox_chan *chan) unsigned long flags; void __iomem *base = MBOX_BASE(mdev, instance); - spin_lock_irqsave(&mdev->lock, flags); + raw_spin_lock_irqsave(&mdev->lock, flags); mdev->enabled[instance] |= BIT(channel); writel_relaxed(BIT(channel), base + STI_ENA_SET_OFFSET); - spin_unlock_irqrestore(&mdev->lock, flags); + raw_spin_unlock_irqrestore(&mdev->lock, flags); } static void sti_mbox_disable_channel(struct mbox_chan *chan) @@ -144,10 +144,10 @@ static void sti_mbox_disable_channel(struct mbox_chan *chan) unsigned long flags; void __iomem *base = MBOX_BASE(mdev, instance); - spin_lock_irqsave(&mdev->lock, flags); + raw_spin_lock_irqsave(&mdev->lock, flags); mdev->enabled[instance] &= ~BIT(channel); writel_relaxed(BIT(channel), base + STI_ENA_CLR_OFFSET); - spin_unlock_irqrestore(&mdev->lock, flags); + raw_spin_unlock_irqrestore(&mdev->lock, flags); } static void sti_mbox_clear_irq(struct mbox_chan *chan) @@ -450,7 +450,7 @@ static int sti_mbox_probe(struct platform_device *pdev) mdev->dev = &pdev->dev; mdev->mbox = mbox; - spin_lock_init(&mdev->lock); + raw_spin_lock_init(&mdev->lock); /* STi Mailbox does not have a Tx-Done or Tx-Ready IRQ */ mbox->txdone_irq = false; -- 2.7.4