public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Baoquan He <bhe@redhat.com>
Subject: [PATCH v1 RESEND 0/2] x86/mm/KASLR: EFI region is mistakenly included into KASLR VA space for randomization
Date: Thu, 23 Mar 2017 11:27:33 +0800	[thread overview]
Message-ID: <1490239655-20902-1-git-send-email-bhe@redhat.com> (raw)

Now EFI region is mistakenly counted into KASLR VA space for randomization
because of misusing EFI_VA_START macro and assuming EFI_VA_START < EFI_VA_END.
In fact EFI region reserved for runtime services virtual mapping will be
allocated using a top-down schema. It will be reused by kexec/kdump kernel.

So the mistake will cause failure because vmemmap may be randomized to own
EFI region and stomped on the EFI virtual mapping. It's need be fixed.

The original post can be found in below link. And this repost just updated
patch log, no new code change. The patch 1/2 need be added to stabe kernel
after 4.8+.

https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1347835.html

Baoquan He (2):
  x86/mm/KASLR: EFI region is mistakenly included into KASLR VA space
    for randomization
  x86/efi: Clean up a minor mistake in code comment

 arch/x86/mm/kaslr.c            | 4 ++--
 arch/x86/platform/efi/efi_64.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.5.5

             reply	other threads:[~2017-03-23  3:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23  3:27 Baoquan He [this message]
2017-03-23  3:27 ` [PATCH v1 RESEND 1/2] x86/mm/KASLR: EFI region is mistakenly included into KASLR VA space for randomization Baoquan He
2017-03-24  0:41   ` Baoquan He
2017-03-24  2:29   ` Dave Young
2017-03-24  3:05     ` Dave Young
2017-03-24  4:35     ` Baoquan He
2017-03-23  3:27 ` [PATCH v1 RESEND 2/2] x86/efi: Clean up a minor mistake in code comment Baoquan He
2017-03-24  8:57   ` Ard Biesheuvel
2017-03-24  9:04     ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490239655-20902-1-git-send-email-bhe@redhat.com \
    --to=bhe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox