From: Joe Perches <joe@perches.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>,
"John 'Warthog9' Hawley" <warthog9@eaglescrag.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Allow space leading blank lines in email headers
Date: Wed, 22 Mar 2017 23:28:40 -0700 [thread overview]
Message-ID: <1490250520.2041.22.camel@perches.com> (raw)
In-Reply-To: <20170323062057.GE17578@localhost.localdomain>
On Wed, 2017-03-22 at 23:20 -0700, Darren Hart wrote:
> I do have an open question regarding how we're going about testing for the end
> of the header lines. Since we're not just testing for an empty line to separate
> headers and body, there is clearly more going on here - but I'm not sure what it
> is ... so I can't be sure this doesn't have an unintended consequence.
>
> > + $rawline =~ /^(?:commit\b|from\b|[\w-]+:)/i)) {
>
> This appears to be an unrelated change, introducing the non-capturing-group
> (?:) and dropping the superfluous .*$ postfix. Did I get that right?
Exactly right.
The capturing of the initial bit of the match and
testing of the rest of the line is simply unnecessary.
I frequently make localized changes like that when I
notice them. It's not a problem.
cheers, Joe
next prev parent reply other threads:[~2017-03-23 7:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 5:35 [PATCH] checkpatch: Allow space leading blank lines in email headers Joe Perches
2017-03-23 6:20 ` Darren Hart
2017-03-23 6:28 ` Joe Perches [this message]
2017-03-23 15:55 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490250520.2041.22.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog9@eaglescrag.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox