From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933168AbdCWIvU (ORCPT ); Thu, 23 Mar 2017 04:51:20 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36390 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932738AbdCWIvS (ORCPT ); Thu, 23 Mar 2017 04:51:18 -0400 From: Pushkar Jambhlekar To: Lidza Louina , Mark Hounschell , Greg Kroah-Hartman Cc: driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Pushkar Jambhlekar Subject: [PATCH] drivers/staging/dgnc: Removing manual function tracing using dev_dbg Date: Thu, 23 Mar 2017 14:20:53 +0530 Message-Id: <1490259053-3245-1-git-send-email-pushkar.iit@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Current implementation manually traces function using 'dev_dbg'. This way is not needed because of ftrace, making these calls redundant. Signed-off-by: Pushkar Jambhlekar --- drivers/staging/dgnc/dgnc_tty.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index f7e754e..cae0410 100644 --- a/drivers/staging/dgnc/dgnc_tty.c +++ b/drivers/staging/dgnc/dgnc_tty.c @@ -1858,13 +1858,9 @@ static void dgnc_tty_send_xchar(struct tty_struct *tty, char c) if (!bd || bd->magic != DGNC_BOARD_MAGIC) return; - dev_dbg(tty->dev, "dgnc_tty_send_xchar start\n"); - spin_lock_irqsave(&ch->ch_lock, flags); bd->bd_ops->send_immediate_char(ch, c); spin_unlock_irqrestore(&ch->ch_lock, flags); - - dev_dbg(tty->dev, "dgnc_tty_send_xchar finish\n"); } /* Return modem signals to ld. */ -- 2.7.4