From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754858AbdC1Izg (ORCPT ); Tue, 28 Mar 2017 04:55:36 -0400 Received: from gate.crashing.org ([63.228.1.57]:46562 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754641AbdC1Izf (ORCPT ); Tue, 28 Mar 2017 04:55:35 -0400 Message-ID: <1490691283.3177.112.camel@kernel.crashing.org> Subject: Re: [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C driver From: Benjamin Herrenschmidt To: Brendan Higgins , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, joel@jms.id.au, vz@mleia.com, mouse@mayc.ru, clg@kaod.org Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Date: Tue, 28 Mar 2017 19:54:43 +1100 In-Reply-To: <20170328051226.21677-4-brendanhiggins@google.com> References: <20170328051226.21677-1-brendanhiggins@google.com> <20170328051226.21677-4-brendanhiggins@google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-1.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote: > Added device tree binding documentation for Aspeed I2C busses. > > Signed-off-by: Brendan Higgins > + i2c0: i2c-bus@40 { > + #address-cells = <1>; > + #size-cells = <0>; > + #interrupt-cells = <1>; > + reg = <0x40 0x40>; > + compatible = "aspeed,ast2400-i2c-bus"; > + bus = <0>; > + clocks = <&clk_apb>; > + clock-frequency = <100000>; For busses it's more traditional to make this "bus-frequency" but that's a nit and Linux/fdt has not respected that tradition terribly well. If you respin, it might be work changing. The clock-frequency tends to be the frequency of the controller itself. > + status = "disabled"; > + interrupts = <0>; > + interrupt-parent = <&i2c_ic>; > + }; > +};