From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbdC1LxE (ORCPT ); Tue, 28 Mar 2017 07:53:04 -0400 Received: from mail-sn1nam01on0057.outbound.protection.outlook.com ([104.47.32.57]:47953 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752141AbdC1Lw7 (ORCPT ); Tue, 28 Mar 2017 07:52:59 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; Message-ID: <1490701966.3546.24.camel@nxp.com> Subject: Re: [RFC 5/8] regulator: anatop: fix min dropout for bypass mode From: Leonard Crestez To: Mark Brown CC: Liam Girdwood , Viresh Kumar , "Rafael J. Wysocki" , "Shawn Guo" , Sascha Hauer , Robin Gong , Anson Huang , Irina Tirdea , Rob Herring , Mark Rutland , Fabio Estevam , "Octavian Purdila" , , , , Date: Tue, 28 Mar 2017 14:52:46 +0300 In-Reply-To: <20170324125438.5wy3r2mr3g5eaxvy@sirena.org.uk> References: <20170324125438.5wy3r2mr3g5eaxvy@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131351755716982053;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39410400002)(39400400002)(39380400002)(39840400002)(39860400002)(39450400003)(39850400002)(2980300002)(1110001)(1109001)(339900001)(24454002)(199003)(189002)(377424004)(9170700003)(229853002)(38730400002)(2906002)(110136004)(53936002)(2870700001)(6916009)(2950100002)(6246003)(81166006)(8936002)(50226002)(81156014)(39060400002)(8676002)(54906002)(23676002)(85426001)(8656002)(77096006)(4326008)(5820100001)(97736004)(189998001)(106466001)(103116003)(105606002)(305945005)(356003)(5660300001)(50466002)(104016004)(7416002)(47776003)(50986999)(33646002)(36756003)(76176999)(86362001)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR0301MB1968;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD031;1:x1dVjQYBQWlPxPn55yo2GL7FJCe3wiPRFWvbESFcsZuCm2C3IFiWIU1GAtrotGVuLjJLy3/P736fWgkRcTquczoLsRLz6acHHgN5gWq8XbpEzktye2PQWIZZWaahXG9WcZ0ZnoIlkJiL1xzuPSswOflHJOSJtoOPwZjgmxagf8SHpH9JFH2ZS+NYO6sIktbyWoxT28VyMrhJmTQBnY+NuJL42z6N1+4bhwK+grxFmIUi/Ow3SV/yv25/+l9QRPFlBcLF3zDUvw9RVF4A7aBRXSHADYCdP/Xg0k9lkxMgyXEmfwvGiahl8urNqSvkMxlmUFU6XSLCPmDsGK4CAHrkX5aZ6Pt1z6vqNKEy2/B2QeMb8Yn86rMzXrXupOsrEQ4+vxjLy5kEzw+GN6dAWLRliFLiiPFyexvAZtxSl3PECg1SDOmpb0yysn0k/RB/7q4zucLAPUmXsg0f67oJTDWMHIf2nw8ZYfelx+mPyMbhSVz/+9MLqMeqXQ322Q/Fxsg+rIrSGsOJCwx2aExqslbh02cO4iPGGLRmJBFAjO61OeBnqh77/dMB6x1xPGdW6jVmQqlASh0agSXeDk8E/fIJq5YI22VKuzLyAn16GlpGqBVwMhwqzvt6qujZQRKl0K1t X-MS-Office365-Filtering-Correlation-Id: b4a21196-df3c-4c4b-13c4-08d475d0f697 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030255075)(201703131430060)(201703131517066);SRVR:SN1PR0301MB1968; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB1968;3:QCA8H6foM48YmH4Qzcf1BLm1akx+XA2zdrnAazx7p7Ey9LFPvBIrjrORsRQj7eusogGvLCUr7odI8QxJZfjVUy3T9L642+ZzkSZi7o7XmW0p4ESQLawN0EP5DC12gFfirb2Co8gOC3GCs7rsd6bBCS8EWCVrPpbikB7gNN492NCZksLYuGCTUTf/gF+pFZWmggx/XXqUZBwUJwLRVk/MDXXZMPuubNUIGJo7vi6y3AtA8ZVM05k9LDHGcu0sXdfbZS9YNHvGlSCly6o5icZ0AzFe3mhP8Gh8lYoJGjOTRuNlIHUrvYtXXZVzvFXxrINoC9Awl6Oc9dzA2o4rLdYTnf8xM7Yj+alStYK07vcvjVIy3AtkJ4aF6GPOOr3zGRcXA34cmurlLPJDjIHV5ABfkaXi8zmqItYdXJik0WpoXq9b1iHkMV39iE5/Svqs2P1ZppcvWk7G/jtTkO4bVtYSHg== X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB1968;25:hgcEXrT0g2dKCo5edDZFJQHYdhkBv3goIOlYIyHfkKiNcu2rDQqhCyQgOKvMRp1xc43shlXc4YUHmiQ7FD7TJONQeEF/jTDRVfOw2b3Q1rs5TGlS/yvBEjcDQU/oSLirk1ozTJIpOCfeVeT1DGD5MPAbwRRarcT7/0rlFnld3RmOGq+PDRM1uzKCn5YikVUIgiOP/Oo77EsGVu6MAsPu2rCx+P3Uy5q2zyGz8maIWg9cAmT45RLBBpq6J5OMLkmQVbQkUpljNAFA3BZ8a/pK18zmEhLwq3eAjnUtyCI4BbiEBS0I88d1+jx8CMgr9dqZ2IxvQeafX+DeIoKnagPk2CHDVecoZ1o2bdiG7pyoH472rioPmhkGKzO9oLC8QYZOovW+lNqKNpa3XD2rs2RQGP0EOj+jXTrQ8KZ9CQgVOMfVjtTPLe9FhHPw+BL3aVByV6WQnyue9ndzMA62tsVKrA==;31:jWlsYEmjsl4evHAaUNiS8UVBfYiBsUvjmOr8zfm4fOd450rRqLXBptOEswe77tDmHD1XwZD93+unqnDdcA6Jmqke37Ie1fActjJJ+9Idh7US9dyJEj0/hwA3WYLYDDwgocYcZrySQiiXcjY6i3MfbOs551f8sl2tBHEtvWqD2GOGTwgX2FBQtPQcys5PDBKH/oD6f51r+Hnbc4J+ON7Lyqr65aTNxS6UVwjyOODAfFSBGitBaDRC4xnGCy6q3mO0jXC1BV/w3EOxzQ4fxbZaR4JFYSloebSJ2LeYBXgHjiw= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095120)(601004)(2401047)(5005006)(8121501046)(13018025)(13023025)(13017025)(13015025)(13024025)(3002001)(10201501046)(6055026)(6096035)(20161123556025)(20161123561025)(20161123559025)(20161123565025)(201703131430059)(201703131433059)(201703131448059)(201703161259059)(201703151042059)(20161123563025);SRVR:SN1PR0301MB1968;BCL:0;PCL:0;RULEID:(400006);SRVR:SN1PR0301MB1968; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB1968;4:QDjEgxhes/+obPchvNkXbzFlwzXcdKkxo4aoC4h0jcAb4yGw08McOqfrWygB7X+i0DyGe91EkHNK/zNNcCZzRQmKB2M6ZivOd3vCla3qbQdFt+DcWd6u/oNh+ARyXHI/BnKveWX2d/FG3yfglrQMmHYGQklQvbUyqZCWPGwJz8q6P1UDiIVJ5vPZ6owMkk9O0sZ583GnIlPoV7i1bW863CEsGjc7XkZbwcboPNJOIXuqjMVgx/QUooJQfbg4zjb44rD7xb+dAVgkV2Q2mxccf9TeLnAXqFP+1iRfAkxCsucQVWEpJyWDDPgaUkEokU9kvW/m0lyXrwLUloU4yIstFMJCh4/m7R1p0K+iVSNAv+K2g3G76zeajJpvoLqoFdz2bCavp0SEdeIrTQ3U25z25te6T2HYPGAzSdyKli9qu+4KM7sXTGO2B0X5oCrQuZdLKDJVzSYZKBBsSexlQuDa7Tbak1vhQTZTkHA7FW6UZiewIwb8fJfIhA1NSjrKlAvMkhVybPf6xR9kMh68h9/BmMAGK9xTM1tOb0zZluZLomjNdAbmg+yT07f4bFOptctke7l+vYdu6RdZE/IQsFgQgUD2UrFWd6uuZu4uC49NqtkoHDth9RPV19oOtmMkieiIfibiKq5Xg+sa3siOi/tAt6znQi/gV0kxT74G0F6FjJzxO1EeMpo//tYn7t4kWTfJJZckg+EsgDQYRhwDRPQdI3R/5/012urNCK95GG6F0+/Z9gRPm299FXfi+y4+oBr3YBcbvlWk3MQZFV4lbnDlFL+vBW0u3dx5pEQvAnhUfpZRGvyIIf+w1QftTlh3bBCNvwDzTk/sZQylEB7Yq4ilhGAXUAy49cAUYerN7ivZaWnE+KQa53nnoufBery8oHtA X-Forefront-PRVS: 0260457E99 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjAzMDFNQjE5Njg7MjM6QW1KVzJia3N6TzZIa28zeVJlY2VtMU1O?= =?utf-8?B?VUdJUysvZTE1M0thSEUvMjBySklXVmFGS3pLZnJFUTZ0UHhTWThJR3ZQSlZz?= =?utf-8?B?RFhoSTJGQkRxU3hwaHRBVXpyQVN5N1U3U29GMFJ3RmZJamJvR25Tb2hBaUFX?= =?utf-8?B?UHJFOUs5bmNNREw0NVJKeWh1SDVoelU5YitTQ2UrUFovRU14MWU3M3V1cTlx?= =?utf-8?B?VDlnbU1IdDgrS1VkZTlFUjJyMmdrdElQbzlYbklPc2RxYWh3MGU1bzRsV3gw?= =?utf-8?B?eVZhQnB5YkdrWE9PTXJaQlhmT2JIWTEzbll5cU1qNnBQYlY0L0l0UkUvdUwr?= =?utf-8?B?cm5RWUhqTEdCQ2dYT2NhWGcrVStIZEJ0RTZidTVQc2JocjhyMWFlYk4rTXE4?= =?utf-8?B?dHp4WXNuSnFwSXREVGNwNXdXdVAwVUoxVDhDU2c4YUduSVRmTkFNK3c5MHVz?= =?utf-8?B?b3BjVWlkenBTYURQWTE3VFVFNElBa3kvNW9Dbk9iNFRXa0xmSlRyajdYTVpM?= =?utf-8?B?UHpNMDduMjFJZ09UMDBRdExlTFlRRU9CQVZUR056ZktJdVZaVTErMXB0dFcr?= =?utf-8?B?eW5OM25mQWxhRGFFd3I0OE80aFdmclp1VTNicGFmUm90cXVzUmFoOGdpMnJl?= =?utf-8?B?eTJFUCtTRjRNNUoyV0V1SE1sb2pTWDVrSlVySk1FVDRpRzI5ZW1McHBxWXJz?= =?utf-8?B?aEwxOE9iVHJtMFNROXZTUmhucW41VFdaM3hrVlZUL3V3c2hmZTZ6UmdJU1Rn?= =?utf-8?B?bWZZcldYSEt5U1FrRFZiQ3EvblJGWmZLMVhIY3duN3JLZ1czZnZCeG5SMVp4?= =?utf-8?B?QzhKWUprZFNHcnhxR2cxVm1BTzN3aG53Nll6bzBaQXgvaXBxdjQ2NmlFR1Q1?= =?utf-8?B?cGQ1dnpxTm1oMzlZaU1ZR2hNYjZMZ3ZBUEE1RGxUNElNQnJEeUhLemEveWNC?= =?utf-8?B?ZXpaOUhOTE55cmc2TnBZUlg4dkZvcFhVMkJ5aXNvckg5SmdiN1c2S2RiOEh3?= =?utf-8?B?ZWpQVGlPSmN5SXJUak5DR04weERzbWRQTkRtdXl1RkJpSThwbmhWSmR3M3pB?= =?utf-8?B?Q2ltOTlqVmp1cFZLb3pyM1M2ZTBKeE9LNC96WDVuQmZ5dEsyTWVIMEt1aVVv?= =?utf-8?B?Z1IxdXhidW9jZXBmQk11TTRjQnA4NDVCVGJYM3ZndFpYV2RDYkNoS3p3U0t1?= =?utf-8?B?L2JHMWlvbGJsSzd5eTlnbjd5STEyUy9IUlpLMUgrVHUxeDBVMS96VGZWNFRR?= =?utf-8?B?WTFZTWMxc2NhdVBxN1lhVU9BbUZIOUpKNW5JVzdQUDhLa0J6OWIzZUpWR0dw?= =?utf-8?B?NXhFNzlKYXFKcTZxVjc5ZS9kcWU0R2hRMVB6UDRWbFNSemZJU1lIUU0zMUlL?= =?utf-8?B?VzlycEdaTGpTM2NUK3ZsVkNkZWp6QlVWNHBzQXpyVENWbjRLN0ZyV29mdU1a?= =?utf-8?B?R0hWa3FqeWVTL3czelhwSzNWbUJBVkFrWVlYV21HVGNEUHFHWGN5QmJnWERa?= =?utf-8?B?elIyaVJ0ZmM0cDBDazhQK0VZOTZXSjdpTWg3U3MvUXRHYkI1T1ZCRmprdmkv?= =?utf-8?B?bEhFYUlrOFlZZHpnWW9lcldSTmRSMVVNdkZxTUkxdk4wYTR0MlhyS0dpK3hY?= =?utf-8?B?bEdSd3dOWmkyS1FET2NUNVRrT3ZMVE1DQTkvQW9yRjkxS3hwVmd1eGVRVTFo?= =?utf-8?B?Ylcyc0ppdlRsK3YyZENqaXkrK1RiaHNuVEErRHlGMSthSWJaSXZrUWg5YmJ5?= =?utf-8?B?VU0yRTdMUzhDSlBFMkVnVUswSHZtY2FyS2owMXozVmI4M0lJYXBBb2dMbk9m?= =?utf-8?B?MjZ5eWZ0VEJ0QTdMZ0c3TUxtbjdyVmVpcHZqY3JnUmVldWdCNng4WWtub0dE?= =?utf-8?B?aHZmalc3TlFlQThtK3I4eW9IbjVpQTJoeDRabFJQWW5ERnZOV20ydENnTFFi?= =?utf-8?B?d05uQVQ5b1pVYmc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB1968;6:60hT4vkjxzHGiNdc3dwOX69VT+P0kN0fqzpaIelxKoPks+LBL/IWIwM3w32gWIr12sgz9YCDJUIAORW7uIj6DeCRNCLtL6yU+0tRyj/0Wk87WBMuEMh4IZP3VssmZBEN2dfdxZS5Jh2r/Mlm130RokWX6v/cw0HvQKFhul1a38HYNlBZraa7tgTaUEiRCvl8IH2m8vm5fi4kgJucg8IhKZJgdq2Ibh372wNmubzCocu03+mFmhofZdX4c5SeIIGvChQvHTzhBULz1akUqRXpBGdbf4rs7wWZYK5X8F4wyF+L3Tq3u8pHhVY3DMRXjeGaITy1KX+c4ylTBleWpN8h9jFOEZjwltduzD5YXAgkSNNe/DAD+j8N/QOEvJI0cQLMPBljKeo/MUwt5Q4CDhjbFA==;5:HY4RCypau8f8GNneAGqWZWHEgCCdX3JmO3kR+NdODgoCQDTkhrPDRpR5wFyF5bjTqkO1/k1ZUYIv/LyWKvdvescjcNNbieAtTLuMlvzVNWdzrGUeQqNCHnayHUfSHOW513qQw6lTP0n9Gz4/RCVFA7mRpaA6TKVNit8pbBQQVH9SVTsfDEw3tfOVwfLHoJ+d;24:gUAZG7+l7R2+/34DSBWcHTeWv2DP4Bt2EKQZE5X/EzKxYEUQBZNCVwgMA1Gs2YZU3hdLRCRPYEej3i9vJasOYEzCAZQMN5zZa0YnoUHn5Bc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB1968;7:RB+iKx5GkaW5vYS1ljbihlHyeTCILC4VriR/2dez5dNWMnBtighCbXtAdWPUKRpvjoWvhFlnEKiIk9QesPI9HEDxA5FN35I7K0udcqWtD3Fc+Q/v8A5Om8mSk/E+XHNxqxLFG0ZFB0W9dx843ZIR+isaVtrxh3pmtOuQAK5nwZub0j/t2kNWYKyaANfPa+eXvSTBH2JSwpNUNP5gSRx43jb5Nw9Lz4Ve3GCqS9JFhQ8YKuJWxkcGoULC7X/4T8+GGG87HJtDD4cYQM9IPYEguNp0pwXTjB6JycUP8fbf9wOfea2WRUOmsZuOIGct7y3Ne3YztVlA3l75xS94LjJwdw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2017 11:52:51.4642 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1968 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-03-24 at 12:54 +0000, Mark Brown wrote: > On Wed, Mar 22, 2017 at 06:53:07PM +0200, Leonard Crestez wrote: > > + if (anatop_reg->bypass) > > + anatop_reg->rdesc.min_dropout_uV = 0; > > + else > > + anatop_reg->rdesc.min_dropout_uV = LDO_MIN_DROPOUT_UV; > No, this is completely broken - you can't expect to randomly change hthe > regulator description at runtime behind the back of the framework and > expect things to work.  If there is a need to do this we need an > interface for getting the current value and a way to notify of changes. > > That said I would not expect the dropout voltage to be considered at > all when the regulator is bypassed, since the regulator is not > regulating it doesn't need any headroom. It's a more complex solution but this could be handled in the core instead. Basically the core would treat min_dropout_uV as zero if the regulator is currently in bypass mode. In theory a function could be added in regulator_ops to ask a regulator driver what requirements it has for its supply but this does not seem necessary.