From: Joerg Roedel <joro@8bytes.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Joerg Roedel <jroedel@suse.de>, Daniel Drake <drake@endlessm.com>,
Alexander Deucher <Alexander.Deucher@amd.com>
Subject: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS
Date: Tue, 28 Mar 2017 14:16:44 +0200 [thread overview]
Message-ID: <1490703404-4944-1-git-send-email-joro@8bytes.org> (raw)
From: Joerg Roedel <jroedel@suse.de>
ATS is broken on these devices. Under invalidation load, the
GPU does not reply to invalidations anymore, causing
Completion-wait loop timeouts on the AMD IOMMU driver side.
Fix it by not enabling ATS on these devices.
Note that below mentioned commit is not broken, it just
triggers the issue because it might cause invalidation
storms on devices.
Fixes: b1516a14657a ('iommu/amd: Implement flush queue')
Reported-by: Daniel Drake <drake@endlessm.com>
Cc: Daniel Drake <drake@endlessm.com>
Cc: Alexander Deucher <Alexander.Deucher@amd.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
drivers/pci/ats.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c
index eeb9fb2..711bdb2 100644
--- a/drivers/pci/ats.c
+++ b/drivers/pci/ats.c
@@ -17,10 +17,18 @@
#include "pci.h"
+static const struct pci_device_id broken_ats_tbl[] = {
+ { PCI_DEVICE(PCI_VENDOR_ID_AMD, 0x98e4) }, /* AMD Stoney GPU part */
+ { 0 }
+};
+
void pci_ats_init(struct pci_dev *dev)
{
int pos;
+ if (pci_match_id(broken_ats_tbl, dev))
+ return;
+
pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ATS);
if (!pos)
return;
--
1.9.1
next reply other threads:[~2017-03-28 12:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 12:16 Joerg Roedel [this message]
2017-03-28 20:18 ` [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Deucher, Alexander
2017-03-28 20:28 ` Joerg Roedel
2017-03-28 20:37 ` Deucher, Alexander
2017-03-28 20:56 ` 'Joerg Roedel'
2017-03-28 21:13 ` Deucher, Alexander
2017-03-28 22:26 ` 'Joerg Roedel'
2017-03-29 7:15 ` Nath, Arindam
2017-03-29 9:42 ` 'Joerg Roedel'
2017-03-29 9:47 ` Nath, Arindam
2017-03-29 16:21 ` Deucher, Alexander
2017-04-04 16:43 ` Bjorn Helgaas
2017-04-07 12:34 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490703404-4944-1-git-send-email-joro@8bytes.org \
--to=joro@8bytes.org \
--cc=Alexander.Deucher@amd.com \
--cc=bhelgaas@google.com \
--cc=drake@endlessm.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox