From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754621AbdC1PFz (ORCPT ); Tue, 28 Mar 2017 11:05:55 -0400 Received: from mga01.intel.com ([192.55.52.88]:57631 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986AbdC1PFf (ORCPT ); Tue, 28 Mar 2017 11:05:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,236,1486454400"; d="scan'208";a="1128087178" Message-ID: <1490713442.708.33.camel@linux.intel.com> Subject: Re: [PATCH] ACPI / gpio: do not fall back to parsing _CRS when we get a deferral From: Andy Shevchenko To: Dmitry Torokhov , Linus Walleij , Hans de Goede Cc: Alexandre Courbot , Mika Westerberg , "Rafael J. Wysocki" , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 28 Mar 2017 18:04:02 +0300 In-Reply-To: <20170323202138.GA11912@dtor-ws> References: <20170323202138.GA11912@dtor-ws> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-03-23 at 13:21 -0700, Dmitry Torokhov wrote: > If, while locating GPIOs by name, we get probe deferral, we should > immediately report it to caller rather than trying to fall back to > parsing > unnamed GPIOs from _CRS block. +Cc: Hans. Hans, do have any objections on this? Would you ideally give your Tested-by? > > Signed-off-by: Dmitry Torokhov > --- >  drivers/gpio/gpiolib-acpi.c | 4 +++- >  1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c > index a3faefa44f68..d3f9f028a37b 100644 > --- a/drivers/gpio/gpiolib-acpi.c > +++ b/drivers/gpio/gpiolib-acpi.c > @@ -572,8 +572,10 @@ struct gpio_desc *acpi_find_gpio(struct device > *dev, >   } >   >   desc = acpi_get_gpiod_by_index(adev, propname, idx, > &info); > - if (!IS_ERR(desc) || (PTR_ERR(desc) == > -EPROBE_DEFER)) > + if (!IS_ERR(desc)) >   break; > + if (PTR_ERR(desc) == -EPROBE_DEFER) > + return ERR_CAST(desc); >   } >   >   /* Then from plain _CRS GPIOs */ > --  > 2.12.1.500.gab5fba24ee-goog > > -- Andy Shevchenko Intel Finland Oy