From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755754AbdC1UEJ (ORCPT ); Tue, 28 Mar 2017 16:04:09 -0400 Received: from mail-by2nam01on0064.outbound.protection.outlook.com ([104.47.34.64]:20408 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753303AbdC1UEG (ORCPT ); Tue, 28 Mar 2017 16:04:06 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; Message-ID: <1490731431.15830.9.camel@nxp.com> Subject: Re: [RFC 3/8] cpufreq: imx6q: Set max suspend_freq to avoid changes during suspend From: Leonard Crestez To: Viresh Kumar CC: Mark Brown , Liam Girdwood , "Rafael J. Wysocki" , Shawn Guo , Sascha Hauer , Robin Gong , Anson Huang , Irina Tirdea , Rob Herring , Mark Rutland , Fabio Estevam , Octavian Purdila , , , , Date: Tue, 28 Mar 2017 23:03:51 +0300 In-Reply-To: <20170323043427.GE12094@vireshk-i7> References: <20170323043427.GE12094@vireshk-i7> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.5-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131352050388463655;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39860400002)(39450400003)(39850400002)(39380400002)(39400400002)(39840400002)(39410400002)(2980300002)(1110001)(1109001)(339900001)(199003)(24454002)(377424004)(189002)(9170700003)(38730400002)(110136004)(50226002)(103116003)(229853002)(8936002)(57986006)(36756003)(8676002)(50986999)(76176999)(81166006)(4326008)(53936002)(6246003)(33646002)(105606002)(5660300001)(106466001)(7416002)(2950100002)(6916009)(39060400002)(305945005)(189998001)(104016004)(356003)(15650500001)(77096006)(5820100001)(8656002)(47776003)(54906002)(2906002)(50466002)(85426001)(53546009)(23676002)(230700001)(86362001)(99106002)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR03MB190;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD030;1:Zf3NTv4tK0jCX032dczol2xUCRh6gSVvabZ2SkAXbSfpWIGiKa7MUvpQSnfgWorDjqoI0MRE7yT+ZfDnKvVzAUoIsjUNsVnNSw8DTHA4h0Dtbz6FS41PtcQldPVnnUtiN4XxkPJBhx96jV3iT7OrO5vCxVI34vfkgJ12b+fZru2Wqgch0Z1qx09jYxp9YbouJjEDZXIYw10mVp5tzXisxrJZ8F4HMKN7VtOBR0xWeypwkeIJw4zPCZMoWAambNuDJ3/1hNwQk3iEcTeB8Md41B1kg17TsBUAX1A5bO+BXogtepsIZgEwbgAdfnOdpk9tWMiaeh4UbmKXEalS+O3RAz9fEzbsrUP1PfsH81z1Hl8tIA4nzRYRu9T6x3UVPT9Jelp/U+14gGmTVcgXJw8C6NbpnJV5Tt5T1Ih8tq49rDhY2MCJwmmcgvZNvZqLBdSY712UXbRffR/GYLSb1ZbxWlgNd20eu7TSOtCwUF0SwRSlMEU6L9ar3iXloFPZvx6VATHyWsA0PPmnuDiFOWxki0ewlILceV7yqkUHaFGY3Vc4pW2l3vHdYpnzohMRBc/y2K2nxsPvK4SQR2ViOkrulkHH2yD+b6TBaR7zb/Wuf2VDwBEvwdbB/7WZFaizsCvt X-MS-Office365-Filtering-Correlation-Id: 13bdbfed-0b5d-4515-0ec6-08d476159261 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030255075)(201703131430065)(201703131517071);SRVR:BY2PR03MB190; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB190;3:ZV7zFWXkdkegqMccIeeY6WVmCzXen7Pik6yWa8iGYz9aHXjOCEgKrYRhGGxYtR+gCZ4H++1CjDNp1bflzf4p//cQ6QeRmTIi1oBTmV/+8e2Bsr3lDDAU1NdXoDxnI0NbzpAR/w7WyTI2H6j6dI5o6KWUJg0t5Yiaetz10HrguTX/pYCChOiZSZKNSOdMMUe4i3ReiL9sxaNqaHMpuT8qV3rtxKH/b77bLTuUgo9g3TTz5zRbcs2PziKJ4RUPqiqL5JFS1OxysWMPWSXdmKkKeiAGPrkIHx9ZlQlUylX1Qcpyl+sVeHHlxzXgW2kN2F34UvYhmEGp0sNW6b0uAHNxcF/lwqSeK65CFffzL61ZOky62hRsZq6VKrofxUFLj6sHZQDBi/DRHIV2ySdQV8Lb7GfCIAMBnXz7BTnRhViA/UGYmXffvjpGqf86eHDf/TDpcg01vKSa4Y8Y7Q4wCVHe3g==;25:HUdp1y/3J+BwySa3PrBPnJGOpieMHJkTKR4fVNzTTDItqUP7j7TjlJXHsX2eHQexLX6S/fnliuIB26Ee74FfpuyLrwJpZ3EINmu7HdjektejBla15HhdEoGk8srtVOpJQH9a6IWog31dMzzTUF879DU1jVqW1hlEKcpx4NTYDkTcUhmt2TOetxIm3NF156EW0jjeFGFWCRRm3iTHQAD6bS6SiuiVK1Io0OjpN+dWd97k0nM3p+Fhxr5knAZ4rmChHfz3ABlEo/r1/65ucqA0yO27VSo9DsxJ/Cod1GwNFfLn6Bc48QCO8cFIW9Ae0rXOaT0BdeLJPIsYUcQ4nbrwqu4EUOj6lV+OGUcaC4xnUXQSweAnHmHWRmkEMyOBuG0+KCRXQTQj2sWqgeqd1iSxJBja3BqizcHdKUcpThDJohc3AtRBQecnsymgWXNOLS6AdBpDLLlZyhrgLGVoat4PXQ== X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB190;31:LPNTWaOvnRfwctRHqpl79sm9fc0qlrCmT7WHd0Gw0ixXQvHIzIh9gEhdY1s1rT1YfXDJnd94Eo0FrRj6c5FUZDnnno/5pdYsHGyW06qB1G8j6KrWm/O4JPx/FByJ8Fk4qymCpDUMBL/3cue/DTvpvCUJk0259s9xEkbLDFoaXC0+hQuuXYTL0V7GHfdFONX4biAP8qnljCQX/mR+HpDbBJZ+l/pmusTs26Hmzx4N/1YWL85pmtFQaObamQtU1mNuthWVV1kF9L8LkHzXdSmM1g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095125)(601004)(2401047)(13015025)(13024025)(13017025)(13018025)(5005006)(8121501046)(13023025)(3002001)(10201501046)(6055026)(6096035)(20161123556025)(20161123563025)(201703131430065)(201703131433065)(201703131448065)(201703131441065)(201703161259065)(20161123559025)(20161123565025)(20161123561025);SRVR:BY2PR03MB190;BCL:0;PCL:0;RULEID:(400006);SRVR:BY2PR03MB190; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB190;4:6PQpxUwMWNtm8V/1qy0isUCQupFf7Tiwavzn0eOJlyQHqpAZLSKPeMzxBDHkSsgBGRu8K18ow10fMZz7dnuIEaLr2qBEB5X2Gj6sMwn+WvfgZfrx8XyG0da31R2cKHDPDAP01VM29sFHAzVYu+0guL18uiCYrwpUmq42kb0sSY1kNLg2VpUz2kzg4rgNcZx0aVHsVO/TEMvDyiyhpS3evcU9sGiKMZTYjxdTAFaj3qfAUND4fvjFTszIJgpAzB8rcL4TTn2lxSJQSZL8KgYV/TrX0SA0iFCy/ez56UhnCoZTNiSF87itHG1pLGkFgmtn7ltCi8pE6QhtJdrzBGSGfkAw/XRZC/AZxn22Ez8j1OhKI/m/gCTAOkrqL/O+peJF06ewqa5S89H6BSGakNwyh4VSV7WdGrPT9ojJ64p3iBVhMMjC+lvsX+vlVB9/KmuPXQIXydw7j4aAa9WStJEnZbiMn42OZ5Ed12SOtTiarb2VYJQDhx4XtMV9Zg2T+ebPodX0D3uE4OiRRQ/vlPpP4jC9Gp0e/+6s0aQqQbjuKux73bP1nyTvHjlKNi0kyQ+/Peqnpp3hM1VrMHaDi5QBqFy32Q++aWldhcug+pJsrKFyVOWsmeajdeH0QBUNWBWpZXXEch03UqAbB7+ryI75ezlJssYhIEa3eToyJeQWQRcEgT7ucXnD+Eiss6H4gmq5px0ueqeQTm30g5yCU7rqDPfmXR1xxPW7VWJaUD0FRRbDo1Uj6DF7kBFIMQQDnGubyNK+jFTU/XLWKQaJijw2xl1I7u8cqDl/l5kdd/sc04NFhUItN0qnaWqv+bdhHMUNtL5JRjAY5eCVrUiQYzYSfsRN+n/2zgl8gN0lxbzQJt9DA4ZNhUGOk4ZOblQx0YMqPcIsMRkbKvDvo8c/LE2QZIqMR8CZAg5W3p96DmkDjCE= X-Forefront-PRVS: 0260457E99 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjAzTUIxOTA7MjM6ZGE5S2hXcVZJRXVhejdnQWhWVUNIOHh2K2FX?= =?utf-8?B?Q1BIS0JzR2xUaEhJSjFoNUdUZG5zTHlVak5yQ29RSFVXOVpuUDV0dS9mZWlE?= =?utf-8?B?dHZPbWQvS3cwczFjMkZUa2RGeDd5SUx4UlYwbHlORHFySENhV0M3cHBBbkpS?= =?utf-8?B?TklaMUxwNVpNU0ttSVkrYkE3bGlPbHZIeUJVUENXWm1jUnlIejRjZHIzNjZs?= =?utf-8?B?L0pOclJlS0VocW1SM05SSkdxUTFCODBUZnpKN05WNzZmMkJzazFzbkJ4ZTVX?= =?utf-8?B?VnNpejJ4RUZxOEIrcE1QR3hvMWtUVU5NRDVvaC9JdDZkTWlNZTRqNjBrdVQv?= =?utf-8?B?YjZGZnp5emtDdlFiNGt0QmdoOHV0dW5xZHpGZjlrcGtibnNMTGVGcHBJQVIw?= =?utf-8?B?eEp6a0lodU8vZXNlNk5JVzBPa29nRVJQVk1SRzlWbXo1RUpROVN1Q09FYVVO?= =?utf-8?B?WE84Zzl1M3pRb1VKTUlkZEFjL21ndmVDZ0w4cjhkTWdzaXlzM0ZoWXVBRDFD?= =?utf-8?B?U2FyUFZSK20zOVMzdzNxcG5CRVN0djFLMlN1WFcyMVVlQndQQnZlQTRHQ1hE?= =?utf-8?B?UlI2NWJnYjRyYXBNdDhlalJKYTEzSnFuZW93WnhncW9zSllXTHBMa2xXd3RR?= =?utf-8?B?YTZnYVVZZWpsbi9zSjd4MEZoL2xFeUp3SzNRU3JjTVNNcENIakJTM3cyK2N5?= =?utf-8?B?cWpwaXNSMkNoUWgySkJZdUEvMy8zNUY2TTFIeEkyRUdjZ2VENUl2MVBaZ1F6?= =?utf-8?B?VmErcEFNaHRPVmlIQU8wTzlWYkJsWEtNK0o4WitDZ212TGYwTlpTa1J4dml1?= =?utf-8?B?N296MnJBZ0oxRTFiRGhadVNmWUdiU2twbW9XSjVuRk9admxoKzF2KzJGUTB4?= =?utf-8?B?S2RDYzRZeGx5YXdVMi9Lem5wRTJmK2Rjd2h4WWViKzk4bkNuV0V0MlF0dmla?= =?utf-8?B?VUQzcGdZSmZEUEY4RXFzTFdVMlZMR3RJZXMvL2ZnbkJSOWNlTDVBS0F0MmVI?= =?utf-8?B?eDRtTkJMTVJMS1hOazR3VW4yU2x3N2pPTVdNRmZHaTFmUkJFdk5LdHIwVWJB?= =?utf-8?B?Z2lOQlJ3dmxUVSt2TlE4U1dQOVV4dDhET0doWlNyS2FlbG9JQmduL0lONmg2?= =?utf-8?B?VDNTU0ZlY01ub3F1UDV0aFNveTZoK1dZaU14V2VEbmZ3eVY4TzR1K2ZWUlMz?= =?utf-8?B?bjVFaTdacEhiR3NRU2hsT3ZUNHkwYU03NXBHaDZxcEZaSytmZ245dVR6NERL?= =?utf-8?B?MDh0QlBCa1VQMTZFS0tkNGJYNDVCaDFlRTJiVk9SWCs3NGdVVVdVbm4yNThD?= =?utf-8?B?K2VrUnVaclZLTUFFWU44cjVvUHUzQ2RjR2UyRzVuSW51NnBTdk1CWGtOZXc5?= =?utf-8?B?Ny85enBWc0tSaTBHcmpxK1hZOEdFYldublNIUmp6K2R3dkh2UWNicm41VWdT?= =?utf-8?B?Y0E5L1pzdmYyRHpKaXV0K1BUQjN0QlRwT0lUNENpUElLVkpWejhpNlVJSWZZ?= =?utf-8?B?Z0Z6TGhtRmVZRzRFbXZGM0JEc3JmVjByN3QzR01NM21nQXVvZDhGTHZSd1B1?= =?utf-8?B?YWdFMVlUUEpOaVhMUGxNUjJKSGVMaWtJY0NtemNDcGo5ZmxkTGtYaTJ4Uzcw?= =?utf-8?B?YnZQZE14UVZhSUlqdUpQRGYvZGpWVUdKcnhYVVB0SldOMFkwdyt0L1NwVXZj?= =?utf-8?B?M0VRNjA3cHQxMG1KdVNFcjROTjM2dXk2em1rK2N0ZVpXN01CSkRTZmxZZUxr?= =?utf-8?B?ZjQwbFEvanNZamdUeVdjcDBSV2FzSjY2UEJ6WitHZHBuUExLZ0VLZy9YZ1Yw?= =?utf-8?B?SXhXRXZld3poVml0STQ0RmlvbzgzNkdxYWgxTGFleG1XS0VqNm5zRjZXdUFp?= =?utf-8?B?bjFDUEZWZ0lNMmpKT1hLL3RVRmg5YURXcDQ4Zmw0MHZ6cThBKzVYT0paSjVI?= =?utf-8?B?azhjTkp1cUJRN0laQmNOMUt0M1JpbVRXL0hoSG1lZi95V0xMNk8vMjBrMG5m?= =?utf-8?Q?3Fofm?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB190;6:iwfIS3GmFcaaHkA13LQiFCZdMqaY1ih/3PL85RtAwUA8AvBA95zNVCvUK8HwZ7pN7iB2D6rq3/DAgvEWbyZ8j+BDD4zLzeoV8Us7hcxtK9f8zMmVNbvflIJPERD1mIihinX7FfCERGln5HZuv2Jz9wWnPAo8PenjTJYA+DxSKG362Ep925p3xbtQypjtKrauAJW8+H7HarxIVKXTXmEX4NHWwAZiR9omdgEkZvqHli2cWtQHI/Rz2FTWA8H+Ntb2Y55Lb5PA1+wv1mvjX9KxqqZQQwrxDWO0RhhEDapNOCyL0qSKW7g31ORku3A6xraET7kTEgWR6nv5EQNl0kIsnZlU2k2wQ2rVp4mKqJAzQ9FlmUlFz+T3oYxFrmEzhO+Lan6ftV1sxYCp/K513lQYeQ==;5:AbJZx9K6nSoqtOVxcNnsHs5Ct0a/baXG3kUAm4TmQcWiPPUBvYfPjKwCc5Dwwf3fymxFSIBbwmaVTOQZZdZn1YiHrx7UkSO3kT16lPj2eLA5moESdZIHVLb0FelSAhAM9y63Wd+ZtGEKQboqvtO/XX8H0JTLPaadMhu7P+Mby8GlfS7sZiEPkLQTKii55+i0;24:TwiQ+UvsTHex/2/q06AGW0W7IE+UgpL85vJw/lIuBBj8vdif2NSvbCOB/uV81GBdRR1zQaBjpUm5tbDopmkDtl2PeXc+c1jTzt3K1ZwTfG0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB190;7:65vYZOOA/OoLnfCqUBHzdecfxXdRpOER42ygMxllteCgW4wwCEIhaN9KumsDkRaeMk2SodjMvclOURg82Ev/MSjGPeIu3mmSJ3jkH6u7U3oXA7MSQa9EjWe716xFrHZqtsEmZqpjMZw8txFjEnKvxH5CFzpsBj+TC/YcqkIyk/YJlxJt/7jrbYgC9i2tjzi+Qh72YLPWcdY/eHFFfWctW8hjgWeYVFG8TmE5A3unaEE/OcWKg5iz/GdYaXFziCSWpv4B4kFWfJ81xEgq9fjb/NTuk0PLbMHH1NiZipatFN90a1YJHX9lDwFMkiPoKe9lv9YpHPN0mji7igpv/utqtg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2017 20:03:57.4423 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB190 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-03-23 at 10:04 +0530, Viresh Kumar wrote: > On 22-03-17, 18:53, Leonard Crestez wrote: > > If the cpufreq driver tries to modify voltage/freq during suspend/resume > > it might need to control an external PMIC via I2C or SPI but those > > devices might be already suspended. > > > > To avoid this scenario we just increase cpufreq to highest setpoint > > before suspend. This issue can easily be triggered by ldo-bypass but in > > theory any regulator set_voltage call can end up having to modify > > external supply voltages. > > > > Signed-off-by: Leonard Crestez > > --- > > drivers/cpufreq/imx6q-cpufreq.c | 2 ++ > > 1 file changed, 2 insertions(+) > > Acked-by: Viresh Kumar The first couple of patches are obvious fixes despite being marked as RFC. It would be great if you could apply them to your tree separately from the rest of the series but I'm not sure what the process is here.