From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932356AbdC2LjA (ORCPT ); Wed, 29 Mar 2017 07:39:00 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:54931 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756041AbdC2Lhw (ORCPT ); Wed, 29 Mar 2017 07:37:52 -0400 Subject: Re: [PATCH 0/2] Fix sysfs recursive removal splats in isci From: James Bottomley To: Johannes Thumshirn , "Martin K . Petersen" Cc: Tejun Heo , Dan Williams , John Garry , Jack Wang , Hannes Reinecke , Linux SCSI Mailinglist , Linux Kernel Mailinglist Date: Wed, 29 Mar 2017 07:37:42 -0400 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17032911-0048-0000-0000-000001415359 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006870; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000206; SDB=6.00840312; UDB=6.00413563; IPR=6.00618284; BA=6.00005247; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014851; XFM=3.00000013; UTC=2017-03-29 11:37:50 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17032911-0049-0000-0000-0000401139A3 Message-Id: <1490787462.2657.3.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-29_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703290099 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-03-29 at 11:41 +0200, Johannes Thumshirn wrote: > This series fixes a sysfs warning caused by isci not being able to > cope with recursive sysfs path removals which are in place since > commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive"). > > The mvsas, aic94xx and pm8001 and hisi_sas patches have been compile > tested only hence they have no callstack of the affected path in > their changelogs. > > I'm not sure whether to mark this patches as stable or not. I tend to > say no here, although we've seen complaints/bug reports on lkml and > the scsi list. What happens to the SYNC CACHE for devices with write back caches? It looks like you've already torn down most of the sas objects by the time they're sent, so do they actually reach the device (or worse, do they hang the system by not making progress)? Assuming the above is OK, what about putting the state change inside sas_remove_ha()? It's better than making every driver do it. James