From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: "Wolfram Sang" <wsa@the-dreams.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jason Cooper" <jason@lakedaemon.net>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Joel Stanley" <joel@jms.id.au>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Kachalov Anton" <mouse@mayc.ru>,
"Cédric Le Goater" <clg@kaod.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"OpenBMC Maillist" <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH v6 1/5] irqchip/aspeed-i2c-ic: binding docs for Aspeed I2C Interrupt Controller
Date: Thu, 30 Mar 2017 08:17:15 +1100 [thread overview]
Message-ID: <1490822235.3177.192.camel@kernel.crashing.org> (raw)
In-Reply-To: <CAFd5g460U4c3rMtKphxnu=OADTfD=oe8Z+JPn-H82zpHKJUqfw@mail.gmail.com>
On Wed, 2017-03-29 at 13:51 -0700, Brendan Higgins wrote:
> so maybe instead of setting a hard limit like I did, maybe the best
> thing is to just check and see what the base_clk gets set to and if
> it gets set to zero, we turn on high speed mode. What do you think?
Ah maybe. Did you scope it to see if clock_hi/low do indeed apply in
high speed mode ?
I wonder if that bit does other things.. I would be interesting to
check. Ohterwise why have the bit rather than just have the driver
write 0 to the divisor ?
The doc for the high speed mode bit says "high speed mode (3.4Mbps)"
which is why I, maybe incorrectly, assumed it was a fixed frequency.
Anyway, not a huge deal at this point, but something to look into
at some stage.
Cheers,
Ben.
next prev parent reply other threads:[~2017-03-29 21:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 5:12 [PATCH v6 0/5] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2017-03-28 5:12 ` [PATCH v6 1/5] irqchip/aspeed-i2c-ic: binding docs for Aspeed I2C Interrupt Controller Brendan Higgins
2017-03-28 8:49 ` Benjamin Herrenschmidt
2017-03-29 10:34 ` Brendan Higgins
2017-03-29 12:11 ` Benjamin Herrenschmidt
2017-03-29 20:51 ` Brendan Higgins
2017-03-29 21:17 ` Benjamin Herrenschmidt [this message]
2017-04-03 14:16 ` Rob Herring
2017-03-28 5:12 ` [PATCH v6 2/5] irqchip/aspeed-i2c-ic: Add I2C IRQ controller for Aspeed Brendan Higgins
2017-03-28 8:32 ` Marc Zyngier
2017-03-28 9:12 ` Benjamin Herrenschmidt
2017-03-28 9:40 ` Marc Zyngier
2017-03-28 20:50 ` Benjamin Herrenschmidt
2017-03-29 9:59 ` Brendan Higgins
2017-03-29 10:55 ` Marc Zyngier
2017-03-28 8:52 ` Benjamin Herrenschmidt
2017-03-29 10:58 ` Joel Stanley
2017-03-29 20:16 ` Brendan Higgins
2017-03-28 5:12 ` [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins
2017-03-28 8:54 ` Benjamin Herrenschmidt
2017-03-29 10:25 ` Brendan Higgins
2017-04-03 14:22 ` Rob Herring
2017-04-03 14:24 ` Rob Herring
2017-03-28 5:12 ` [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2017-03-28 8:57 ` Benjamin Herrenschmidt
2017-03-28 9:09 ` Benjamin Herrenschmidt
2017-03-29 10:23 ` Brendan Higgins
2017-03-31 0:33 ` Joel Stanley
2017-03-31 7:33 ` Benjamin Herrenschmidt
2017-04-24 18:56 ` Brendan Higgins
2017-04-25 2:19 ` Benjamin Herrenschmidt
2017-04-25 8:32 ` Brendan Higgins
2017-04-25 8:50 ` Ryan Chen
2017-04-25 9:34 ` Benjamin Herrenschmidt
2017-04-25 9:47 ` Ryan Chen
2017-04-25 19:50 ` Brendan Higgins
2017-04-26 0:52 ` Ryan Chen
2017-03-28 5:12 ` [PATCH v6 5/5] i2c: aspeed: added slave support for Aspeed I2C driver Brendan Higgins
2017-03-31 0:01 ` [PATCH v6 0/5] i2c: aspeed: added driver for Aspeed I2C Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490822235.3177.192.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=clg@kaod.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=joel@jms.id.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mouse@mayc.ru \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=vz@mleia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox