From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932641AbdC3Da5 (ORCPT ); Wed, 29 Mar 2017 23:30:57 -0400 Received: from mout.gmx.net ([212.227.15.19]:56370 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752742AbdC3Daz (ORCPT ); Wed, 29 Mar 2017 23:30:55 -0400 Message-ID: <1490844642.4167.28.camel@gmx.de> Subject: Re: [PATCH] virtio_console: fix uninitialized variable use From: Mike Galbraith To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Greg Kroah-Hartman , Amit Shah , virtualization@lists.linux-foundation.org Date: Thu, 30 Mar 2017 05:30:42 +0200 In-Reply-To: <1490819164-7648-1-git-send-email-mst@redhat.com> References: <1490819164-7648-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:J163S/hKhIstjzgDF7i7jT4ry4vO9AbsJsp/dftU6WT3Xg3k+5p SeFL/NTgwxGT8qKlvuWHg4qrcHrhZA4xvI/wRv7lWvq6ps+nHfTrZaxf8RwaIMz9Kx3z5+M rJ/LZTWYIRgazuocELgvC/ETs9rXFpnysoCU9ZkryjWhhN/hv/8Sx1+egmDsLawg/hFE7Ru OweyfQ+gCfUF7759EGvRQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:AB5HP9IMnrE=:uM3j2zarPoV51jXcotniBa rknwuk9lBwY3pe23qK0KEXS4zKlnKjYcVZAkVTcFxy37xwNscjWX+pg2bjsUGhD7IXsEZJlWZ Eu0/CZljx/4O+QfuM7QbYbT4+7Mop/FDHbJYUgS8rjtem5DKogQTiNYuexng8J1Wu0yeEjP5x K7JYMi0BNS0ObfUqznlmyqYRxyX1DptO0p/7EqyCcQD37gv3zMDvF+2a00T22kg6jk48X04TV 3NVRE9Ivl47Q3xQK4z/G1eWODdH6bbZQCTY/wocc88iAp7sLysszns+gT7vUlXfqRS5MzyakV W7xPA8FsZvUeLE14XjsqOyeKaKB144GtuRIQlUn8Q/czapraZ+9/AKj4XScvtJsbdQkGTvEMo uJRTMeJdHia+qZCUczwQscyC04rixENqGNNI1aNEgLdyTXfpdYQCJnqxKD9q0bkfc2tf64wlg 5SX3OUdOLRv3GNudCH9u8x8r65kted5IgQax0g7VlOiV+wxRHOtUkWod92rxq6daJStgl3BIf i+RXZ2scYi3+sSrSPrEm+c7ajm/Waf3iLjf5k4+2tUpnKTtqvW7y7eP2l5vBaOnd6Kxm3HE+n cQZ6uQzwEk1HInCFGObhHaY04mWfTpz6vrAVVHsOWUfy2K38qzI5a2MEJH4CzL9lhJWSF6NzV AcbAfoCBXuGNaZb/eIQvZQjVMCEgfvdf+6XaqHoBuTRKLIMssmbolbYFUG4V3WxLvZgHZUx4L hXm7bgKK5XWmpP24TPoeBGf/8WBUEYbP0HF4mqE2HApnqeToBFQG2KCwxhZiW33uHeRMTIeO2 bqbn5rn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-03-29 at 23:27 +0300, Michael S. Tsirkin wrote: > Hi Mike > if you like, pls send me your Signed-off-by and I'll > change the patch to make you an author. Nah, it's perfect as it is. While I was pretty darn sure it was generic, I intentionally posted it as diagnostic info. > More importantly, pls let me know whether this helps > resolve the issues about hybernation for you! Well, it prevents kaboom with VIRTIO_CONSOLE_F_MULTIPORT turned off, but no, it does nada wrt the warnings. -Mike