From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754447AbdC3JtU (ORCPT ); Thu, 30 Mar 2017 05:49:20 -0400 Received: from mga01.intel.com ([192.55.52.88]:1037 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753971AbdC3JtS (ORCPT ); Thu, 30 Mar 2017 05:49:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,246,1486454400"; d="scan'208";a="949738062" Message-ID: <1490867082.708.58.camel@linux.intel.com> Subject: Re: [PATCH v1] x86/platform/intel-mid: Enable bluetooth on Intel Edison From: Andy Shevchenko To: Ingo Molnar Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Date: Thu, 30 Mar 2017 12:44:42 +0300 In-Reply-To: <20170330072345.GB12758@gmail.com> References: <20170329141815.34228-1-andriy.shevchenko@linux.intel.com> <20170330072345.GB12758@gmail.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-03-30 at 09:23 +0200, Ingo Molnar wrote: > * Andy Shevchenko wrote: > > > Intel Edison has Wi-Fi + BT module attached and, since it's an SFI- > > enumerated > > platform, needs a platform data. Here we add bits to enable > > bluetooth device. > > + > > +static struct gpiod_lookup_table tng_bt_sfi_gpio_table = { > > + .dev_id = "hci_bcm", > > + .table = { > > + GPIO_LOOKUP("0000:00:0c.0", -1, "device-wakeup", > > GPIO_ACTIVE_HIGH), > > + GPIO_LOOKUP("0000:00:0c.0", -1, "shutdown", > > GPIO_ACTIVE_HIGH), > > + GPIO_LOOKUP("0000:00:0c.0", -1, "host-wakeup", > > GPIO_ACTIVE_HIGH), > > Minor nit: just out of general principle (because the rest of the code > looks so  > nice) I'd properly tabulate the last column as well - something like: > > GPIO_LOOKUP("0000:00:0c.0", -1, "device-wakeup", > GPIO_ACTIVE_HIGH), > GPIO_LOOKUP("0000:00:0c.0", -1, > "shutdown",      GPIO_ACTIVE_HIGH), > GPIO_LOOKUP("0000:00:0c.0", -1, "host- > wakeup",   GPIO_ACTIVE_HIGH), > > Formatted that way the reviewer's eye can skip over those values in > 100  > milliseconds, determining that all 3 values are GPIO_ACTIVE_HIGH. Thanks for a hint. Should I resend it? -- Andy Shevchenko Intel Finland Oy