From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933442AbdCaPhn (ORCPT <rfc822;w@1wt.eu>);
        Fri, 31 Mar 2017 11:37:43 -0400
Received: from mail-wr0-f170.google.com ([209.85.128.170]:35468 "EHLO
        mail-wr0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933297AbdCaPhl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 31 Mar 2017 11:37:41 -0400
Message-ID: <1490974657.12951.5.camel@baylibre.com>
Subject: Re: [PATCH v2,1/3] meson_uart: expose CLKID_UARTx
From: Jerome Brunet <jbrunet@baylibre.com>
To: Kevin Hilman <khilman@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Helmut Klein <hgkr.klein@gmail.com>, mturquette@baylibre.com,
        sboyd@codeaurora.org, devicetree@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org
Date: Fri, 31 Mar 2017 17:37:37 +0200
In-Reply-To: <m2y3vn6dhk.fsf@baylibre.com>
References: <20170328092545.4644-1-hgkr.klein@gmail.com>
         <20170328092545.4644-2-hgkr.klein@gmail.com>
         <1490716277.20764.6.camel@baylibre.com>
         <71489b62-78c8-7082-587e-8598dc43ca59@gmail.com>
         <1490728490.20764.8.camel@baylibre.com>
         <CAFBinCDF29+kQpedsJPqRy6fztWrj91Qi6tCno_2S6UCkhW7XQ@mail.gmail.com>
         <m2y3vn6dhk.fsf@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-03-29 at 13:21 -0700, Kevin Hilman wrote:
> Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> 
> [...]
> 
> > for Helmut this would mean that instead of dropping this patch (or
> > dropping CLKID_UART1 and CLKID_UART2 from this patch) he would rather
> > have to *add* another patch (for meson-gxbb.dtsi and meson-gxl.dtsi)
> > which passes the core clocks to the corresponding UART controllers
> > (similar to the CLKID_SD_EMMC_ clocks).
> 
> Yes, this is what I would like to see.
> 
> If a new CLKID is exposed, I want to see the users of it at the same
> time.

Helmut,

If you send another version of these patches, considering the feedback of Kevin
and Martin, could you please change the subject of this patch to:

dt-bindings: clock: gxbb: expose UART clocks

Thx
Jerome

> 
> Kevin