From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750872AbdDACHm (ORCPT ); Fri, 31 Mar 2017 22:07:42 -0400 Received: from smtprelay0063.hostedemail.com ([216.40.44.63]:54967 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750710AbdDACHm (ORCPT ); Fri, 31 Mar 2017 22:07:42 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3873:4321:4605:5007:6119:7901:10004:10400:10848:11026:11232:11473:11658:11914:12043:12048:12740:12760:12895:13069:13161:13229:13311:13357:13439:14659:21080:21451:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: end54_422f8e8b7390a X-Filterd-Recvd-Size: 1921 Message-ID: <1491012453.27353.25.camel@perches.com> Subject: Re: [PATCH] dm ioctl: Remove double parentheses From: Joe Perches To: Matthias Kaehlcke , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com Cc: Shaohua Li , linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Grant Grundler , Michael Davidson , Greg Hackmann Date: Fri, 31 Mar 2017 19:07:33 -0700 In-Reply-To: <20170401015019.GA13986@google.com> References: <20170316164830.127026-1-mka@chromium.org> <20170401015019.GA13986@google.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-03-31 at 18:50 -0700, Matthias Kaehlcke wrote: > El Thu, Mar 16, 2017 at 09:48:30AM -0700 Matthias Kaehlcke ha dit: > > > The extra pair of parantheses is not needed and causes clang to generate > > the following warning: > > > > drivers/md/dm-ioctl.c:1776:11: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] > > if ((cmd == DM_DEV_CREATE_CMD)) { > > ~~~~^~~~~~~~~~~~~~~~~~~~ > > drivers/md/dm-ioctl.c:1776:11: note: remove extraneous parentheses around the comparison to silence this warning > > if ((cmd == DM_DEV_CREATE_CMD)) { > > ~ ^ ~ > > drivers/md/dm-ioctl.c:1776:11: note: use '=' to turn this equality comparison into an assignment > > if ((cmd == DM_DEV_CREATE_CMD)) { There are dozens of these comparisons in the kernel. Are you fixing them all or just this one?