From: Joe Perches <joe@perches.com>
To: Chewie Lin <linsh@oregonstate.edu>
Cc: Randy Dunlap <rdunlap@infradead.org>,
greg@kroah.com, forest@alittletooquiet.net,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning
Date: Fri, 31 Mar 2017 20:33:46 -0700 [thread overview]
Message-ID: <1491017626.27353.31.camel@perches.com> (raw)
In-Reply-To: <20170401031851.GA9149@Cassini.Home>
On Fri, 2017-03-31 at 20:18 -0700, Chewie Lin wrote:
> These are good points, but any feedback on the dev_warn() call itself?
> I was trying to fix the checkpatch warning on my first try.
Using "%s" with a long string is generally inefficient.
Compare the compiled object size of
printf("%s is %d\n", "Long string", 1);
to
printf("Long string is %d\n", 1);
next prev parent reply other threads:[~2017-04-01 3:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 1:59 [PATCH] eudyptula challenge Chewie Lin
2017-04-01 1:59 ` [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
2017-04-01 2:15 ` Randy Dunlap
2017-04-01 2:45 ` Joe Perches
2017-04-01 3:18 ` Chewie Lin
2017-04-01 3:33 ` Joe Perches [this message]
2017-04-01 2:16 ` Joe Perches
2017-04-01 3:32 ` Al Viro
2017-04-01 3:36 ` Joe Perches
2017-04-01 3:46 ` Al Viro
2017-04-01 3:52 ` Joe Perches
2017-04-01 4:08 ` Al Viro
2017-04-01 4:27 ` Joe Perches
2017-04-01 4:33 ` Chewie Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491017626.27353.31.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=greg@kroah.com \
--cc=linsh@oregonstate.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox