public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Chewie Lin <linsh@oregonstate.edu>,
	greg@kroah.com, forest@alittletooquiet.net,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning
Date: Fri, 31 Mar 2017 20:52:50 -0700	[thread overview]
Message-ID: <1491018770.27353.35.camel@perches.com> (raw)
In-Reply-To: <20170401034623.GE29622@ZenIV.linux.org.uk>

On Sat, 2017-04-01 at 04:46 +0100, Al Viro wrote:
> On Fri, Mar 31, 2017 at 08:36:22PM -0700, Joe Perches wrote:
> > On Sat, 2017-04-01 at 04:32 +0100, Al Viro wrote:
> > > On Fri, Mar 31, 2017 at 06:59:19PM -0700, Chewie Lin wrote:
> > > > Replace string with formatted arguments in the dev_warn() call. It removes
> > > > the checkpatch warning:
> > > > 
> > > > 	WARNING: Prefer using "%s", __func__ to embedded function names
> > 
> > []
> > > Again, checkpatch warning is badly written
> > 
> > In your opinion, what wording would be better?
> 
> MILD SUGGESTION: don't spell the function name out in format strings;
> 	"this_function: foo is %d", n
> might be better off as
> 	"%s: foo is %d", __func__, n
> in case you ever move it to another function or rename your function.

Thank you sir, may I have another.

checkpatch messages are single line.

  reply	other threads:[~2017-04-01  3:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01  1:59 [PATCH] eudyptula challenge Chewie Lin
2017-04-01  1:59 ` [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
2017-04-01  2:15   ` Randy Dunlap
2017-04-01  2:45     ` Joe Perches
2017-04-01  3:18       ` Chewie Lin
2017-04-01  3:33         ` Joe Perches
2017-04-01  2:16   ` Joe Perches
2017-04-01  3:32   ` Al Viro
2017-04-01  3:36     ` Joe Perches
2017-04-01  3:46       ` Al Viro
2017-04-01  3:52         ` Joe Perches [this message]
2017-04-01  4:08           ` Al Viro
2017-04-01  4:27             ` Joe Perches
2017-04-01  4:33     ` Chewie Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491018770.27353.35.camel@perches.com \
    --to=joe@perches.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=forest@alittletooquiet.net \
    --cc=greg@kroah.com \
    --cc=linsh@oregonstate.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox