From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Joel Stanley <joel@jms.id.au>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>, Jeremy Kerr <jk@ozlabs.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
openbmc@lists.ozlabs.org, devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] drivers/serial: Add driver for Aspeed virtual UART
Date: Mon, 03 Apr 2017 07:09:43 +1000 [thread overview]
Message-ID: <1491167383.26047.15.camel@kernel.crashing.org> (raw)
In-Reply-To: <CAHp75VfmbHrPFXO3UFmSciCnVuoB+5vFxy7iOnwVS5YBSPO3+Q@mail.gmail.com>
On Sun, 2017-04-02 at 16:07 +0300, Andy Shevchenko wrote:
> > + port.port.irqflags = IRQF_SHARED;
>
> This is set by core. You already supplied correct flag for that
> below.
Are you sure ? Where ?
We had a bug the other day because that wasn't being set...
Cheers,
Ben.
next prev parent reply other threads:[~2017-04-02 21:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 5:44 [PATCH 0/2] drivers: serial: Aspeed VUART driver Joel Stanley
2017-03-28 5:44 ` [PATCH 1/2] serial: 8250: Add flag so drivers can avoid THRE probe Joel Stanley
2017-03-28 5:44 ` [PATCH 2/2] drivers/serial: Add driver for Aspeed virtual UART Joel Stanley
2017-03-31 13:31 ` Greg Kroah-Hartman
2017-03-31 21:29 ` Benjamin Herrenschmidt
2017-04-02 13:07 ` Andy Shevchenko
2017-04-02 21:09 ` Benjamin Herrenschmidt [this message]
2017-04-03 7:11 ` Joel Stanley
2017-04-03 14:25 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491167383.26047.15.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox