Re: [PATCH 1/2] mmc: host: MMC_SH_MMCIF should depend on HAS_DMA

Laurent Pinchart
2014-02-21T20:25:47Z

Hi Geert,

Thank you for the patches.

On Friday 21 February 2014 20:52:50 Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `sh_mmcif_start_dma_tx':
> sh_mmcif.c:(.text+0x5a3286): undefined reference to `dma_map_sg'
> drivers/built-in.o: In function `sh_mmcif_start_dma_rx':
> sh_mmcif.c:(.text+0x5a33fc): undefined reference to `dma_map_sg'
> drivers/built-in.o: In function `sh_mmcif_end_cmd':
> sh_mmcif.c:(.text+0x5a3668): undefined reference to `dma_unmap_sg'
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

For both,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 1384f67abe21..bfe2133d0b9c 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -611,7 +611,7 @@ config MMC_DW_PCI
>
> config MMC_SH_MMCIF
> tristate "SuperH Internal MMCIF support"
> - depends on MMC_BLOCK
> + depends on MMC_BLOCK && HAS_DMA
> depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> help
> This selects the MMC Host Interface controller (MMCIF).

--
Regards,

Laurent Pinchart