From: Joe Perches <joe@perches.com>
To: Hugues Fruchet <hugues.fruchet@st.com>,
Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] checkpatch: test missing initial blank line in block comment
Date: Mon, 03 Apr 2017 12:06:40 -0700 [thread overview]
Message-ID: <1491246400.27353.59.camel@perches.com> (raw)
In-Reply-To: <1491206895-24332-2-git-send-email-hugues.fruchet@st.com>
On Mon, 2017-04-03 at 10:08 +0200, Hugues Fruchet wrote:
> Warn when block comments are not starting with blank comment:
>
> /* multiple lines
> * block comment,
> * => warning
> */
>
> /*
> * multiple lines
> * block comment,
> * => no warning
> */
>
> Exception made for networking files where rule is the
> exact opposite.
I recall there was some reason I didn't do this
when adding the block comment code, but I don't
recall what it was. Perhaps it was the initial
line of files.
Maybe your $realline > 2 test fixes it. Maybe not.
Dunno.
If you run this against the entire kernel code
using a unique test type and not BLOCK_COMMENT_STYLE
are there any false positives?
Maybe test with something like:
$ git ls-files -- "*.[ch]" | \
xargs --max-args 20 ./scripts/checkpatch.pl -f --types=<your_unique_test>
next prev parent reply other threads:[~2017-04-03 19:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 8:08 [PATCH v1] checkpatch: test missing initial blank line in block comment Hugues Fruchet
2017-04-03 8:08 ` Hugues Fruchet
2017-04-03 19:06 ` Joe Perches [this message]
2017-04-05 8:23 ` Hugues FRUCHET
2017-04-05 8:35 ` Joe Perches
2017-04-05 9:43 ` Hugues FRUCHET
2017-04-05 9:55 ` Joe Perches
2017-04-05 13:26 ` Hugues FRUCHET
2017-04-07 9:56 ` Hugues FRUCHET
2017-04-07 10:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491246400.27353.59.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=hugues.fruchet@st.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox