linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Peter Hurley <peter@hurleysoftware.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 0/5] minitty: a minimal TTY layer alternative for embedded systems
Date: Tue, 04 Apr 2017 14:40:28 +0100	[thread overview]
Message-ID: <1491313228.3704.42.camel@linux.intel.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1704031433480.1847@knanqh.ubzr>

> But no job control. No line editing with echo when the shell is
> busy, 
> etc.

This is a debug interface. If RAM is that precious do the line editing
on the other end of the link, like normal sane RTOS people do. Most
terminal apps support line by line modes.

> we're down to 5.6K. At which point there's only a raw device
> interface 
> to serial hardware.

Which if you did a simple plain chardev without trying to fake the
rather out of date uart layer would come down way further still.

>  the same low-level UART interface as 
> drivers/tty/serial/serial_core.c is using to interact with UART
> drivers. 
> If someone wants to make a change to that interface, the 30 or so
> UART 
> drivers will have to be changed as well. I don't think that would be
> a 
> big deal to change the minitty code to follow suit. And I won't hide 
> under a rock while this happens.

Fair enough.


> > talks tty layer. In your case you are tying it to something we
> > eventually ought to get rid of.
> 
> You won't get rid of UART drivers, right?

Given infinite time the uart layer ought to go away and be replaced
with a simple kfifo queue.

> vices, though, have 256K of on-chip RAM. Those devices will
> make 
> it into your surrounding. Having so much more RAM (no pun intended) 
> they'll be capable of even more damage. Would you be more confident, 
> when a security issue arises (because it will), to know that some
> Linux 
> code base is used rather than any random RTOS out there with only
> one 
> hundredth of the actual Linux following? If so please indulge me a
> bit.

Actually for any safety critical system both terrify me about as much.
None of them are generally written to any appropriate ISO safety
standard, or in an appropriate language.

I did read your rationale. I am deeply dubious that re-doing the uart
layer is the right approach versus just doing a tiny char device, but
I've said my piece.

Alan

  reply	other threads:[~2017-04-04 13:40 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01 22:21 [PATCH v2 0/5] minitty: a minimal TTY layer alternative for embedded systems Nicolas Pitre
2017-04-01 22:21 ` [PATCH v2 1/5] console: move console_init() out of tty_io.c Nicolas Pitre
2017-04-01 22:21 ` [PATCH v2 2/5] tty: move baudrate handling code to a file of its own Nicolas Pitre
2017-04-01 22:21 ` [PATCH v2 3/5] serial: small Makefile reordering Nicolas Pitre
2017-04-02 12:55   ` Andy Shevchenko
2017-04-02 15:49     ` Nicolas Pitre
2017-04-01 22:21 ` [PATCH v2 4/5] serial: split generic UART driver helper functions into a separate file Nicolas Pitre
2017-04-02 13:16   ` Andy Shevchenko
2017-04-02 15:44     ` Nicolas Pitre
2017-04-03  7:35   ` kbuild test robot
2017-04-01 22:21 ` [PATCH v2 5/5] minitty: minimal TTY support alternative for serial ports Nicolas Pitre
2017-04-02 13:22 ` [PATCH v2 0/5] minitty: a minimal TTY layer alternative for embedded systems Andy Shevchenko
2017-04-02 15:55   ` Nicolas Pitre
2017-04-03 12:56     ` Alan Cox
2017-04-03 16:06       ` Nicolas Pitre
2017-04-03 18:05         ` Alan Cox
2017-04-03 19:50           ` Nicolas Pitre
2017-04-04 13:40             ` Alan Cox [this message]
2017-04-04 19:26               ` Nicolas Pitre
2017-04-02 20:47 ` Andi Kleen
2017-04-02 21:41   ` Nicolas Pitre
2017-04-02 22:44     ` Stuart Longland
2017-04-03  1:01       ` Nicolas Pitre
2017-04-04  0:39         ` Stuart Longland
2017-04-03 18:14       ` Geert Uytterhoeven
2017-04-03 18:57         ` Rob Herring
2017-04-03 19:46           ` Geert Uytterhoeven
2017-04-03 21:05         ` Andy Shevchenko
2017-04-04 16:59           ` Tom Zanussi
2017-04-04 17:08             ` Andy Shevchenko
2017-04-04 17:59               ` Tom Zanussi
2017-04-04 18:04                 ` Andy Shevchenko
2017-04-04 18:31                   ` Nicolas Pitre
2017-04-04 19:58                   ` Tom Zanussi
2017-04-04 20:27                     ` Nicolas Pitre
2017-04-04 18:53             ` Nicolas Pitre
2017-04-03  7:54     ` Andy Shevchenko
2017-04-03 15:31       ` Andi Kleen
2017-04-03 17:27         ` Nicolas Pitre
2017-04-03 19:57         ` Adam Borowski
2017-04-03 20:09           ` Nicolas Pitre
2017-04-03 20:32             ` Adam Borowski
2017-04-03 16:40       ` Nicolas Pitre
2017-04-03  7:44 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491313228.3704.42.camel@linux.intel.com \
    --to=alan@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=peter@hurleysoftware.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).