From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756123AbdDESRb (ORCPT ); Wed, 5 Apr 2017 14:17:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37022 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755351AbdDESQR (ORCPT ); Wed, 5 Apr 2017 14:16:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 80985C056791 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dledford@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 80985C056791 Message-ID: <1491416174.2923.3.camel@redhat.com> Subject: Re: [PATCH 00/14] RDMA/cxgb: Fine-tuning for several function implementations From: Doug Ledford To: SF Markus Elfring , linux-rdma@vger.kernel.org, Hal Rosenstock , Sean Hefty , Steve Wise Cc: LKML , kernel-janitors@vger.kernel.org Date: Wed, 05 Apr 2017 14:16:14 -0400 In-Reply-To: <0aff92fa-2891-333a-2e1e-ca309db2ec72@users.sourceforge.net> References: <0aff92fa-2891-333a-2e1e-ca309db2ec72@users.sourceforge.net> Organization: Red Hat, Inc. Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 05 Apr 2017 18:16:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-08 at 22:10 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 8 Feb 2017 22:00:10 +0100 > > Several update suggestions were taken into account > from static source code analysis. > > Markus Elfring (14): >   Use kcalloc() in cxio_create_qp() >   Rename jump labels in cxio_create_qp() >   Use kcalloc() in two functions >   Use common error handling code in recover_queues() >   Return an error code only as a constant in ep_open() >   Return an error code only as a constant in stag_open() >   Adjust three checks for null pointers >   Adjust construction of two error messages in recover_lost_dbs() >   Use common error handling code in recover_lost_dbs() >   Use kmalloc_array() in c4iw_id_table_alloc() >   Use kcalloc() in create_qp() >   Delete an unnecessary variable initialisation in create_qp() >   Rename jump labels in c4iw_create_qp() >   Rename jump labels in rdma_init() > >  drivers/infiniband/hw/cxgb3/cxio_hal.c | 20 ++++---- >  drivers/infiniband/hw/cxgb4/device.c   | 83 +++++++++++++++--------- > ---------- >  drivers/infiniband/hw/cxgb4/id_table.c |  5 +- >  drivers/infiniband/hw/cxgb4/qp.c       | 48 ++++++++++---------- >  4 files changed, 75 insertions(+), 81 deletions(-) I didn't see enough value in this series to bother picking it up.  Steve, if there are any patches out of this series you actually want, please collect them and forward them on to me. -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD