From: Mike Galbraith <efault@gmx.de>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Mel Gorman <mgorman@techsingularity.net>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH] sched: Fix numabalancing to work with isolated cpus
Date: Thu, 06 Apr 2017 09:36:50 +0200 [thread overview]
Message-ID: <1491464210.4718.82.camel@gmx.de> (raw)
In-Reply-To: <1491326848-5748-1-git-send-email-srikar@linux.vnet.ibm.com>
On Tue, 2017-04-04 at 22:57 +0530, Srikar Dronamraju wrote:
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index f045a35..f853dc0 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -1666,6 +1666,10 @@ static void task_numa_find_cpu(struct task_numa_env *env,
> > > > if (!cpumask_test_cpu(cpu, &env->p->cpus_allowed))
> > > > > continue;
>
> +> > > /* Skip isolated cpus */
> +> > > if (cpumask_test_cpu(cpu, cpu_isolated_map))
> +> > > > continue;
Methinks that should check for !cpu_rq(cpu)->sd, so the thing doesn't
screw up cpuset isolation either.
-Mike
next prev parent reply other threads:[~2017-04-06 7:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 17:27 [PATCH] sched: Fix numabalancing to work with isolated cpus Srikar Dronamraju
2017-04-04 18:56 ` Rik van Riel
2017-04-04 20:37 ` Mel Gorman
2017-04-05 1:50 ` Srikar Dronamraju
2017-04-05 8:09 ` Mel Gorman
2017-04-05 12:57 ` Michal Hocko
2017-04-05 15:22 ` Srikar Dronamraju
2017-04-05 16:44 ` Michal Hocko
2017-04-06 7:19 ` Srikar Dronamraju
2017-04-06 7:34 ` Michal Hocko
2017-04-06 9:23 ` Peter Zijlstra
2017-04-06 10:13 ` Michal Hocko
2017-04-06 10:29 ` Peter Zijlstra
2017-04-06 10:42 ` Michal Hocko
2017-04-06 10:47 ` Peter Zijlstra
2017-04-06 13:44 ` Michal Hocko
2017-04-06 7:36 ` Mike Galbraith [this message]
2017-04-06 7:36 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491464210.4718.82.camel@gmx.de \
--to=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox