From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754311AbdDFV3e (ORCPT ); Thu, 6 Apr 2017 17:29:34 -0400 Received: from smtprelay0234.hostedemail.com ([216.40.44.234]:41408 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751039AbdDFV31 (ORCPT ); Thu, 6 Apr 2017 17:29:27 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:4321:5007:7904:10004:10400:10848:11232:11473:11657:11658:11914:12043:12438:12555:12679:12690:12737:12740:12760:12895:13069:13311:13357:13439:14096:14097:14181:14659:14721:21080:21433:21451:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: page48_178efc381cf51 X-Filterd-Recvd-Size: 1924 Message-ID: <1491514160.27353.102.camel@perches.com> Subject: Re: [PATCH] ath9k: Add cast to u8 to FREQ2FBIN macro From: Joe Perches To: Matthias Kaehlcke , Kalle Valo , ath9k Development Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Grant Grundler Date: Thu, 06 Apr 2017 14:29:20 -0700 In-Reply-To: <20170406212135.72157-1-mka@chromium.org> References: <20170406212135.72157-1-mka@chromium.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-04-06 at 14:21 -0700, Matthias Kaehlcke wrote: > The macro results are assigned to u8 variables/fields. Adding the cast > fixes plenty of clang warnings about "implicit conversion from 'int' to > 'u8'". > > Signed-off-by: Matthias Kaehlcke > --- > drivers/net/wireless/ath/ath9k/eeprom.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath9k/eeprom.h b/drivers/net/wireless/ath/ath9k/eeprom.h > index 30bf722e33ed..31390af6c33e 100644 > --- a/drivers/net/wireless/ath/ath9k/eeprom.h > +++ b/drivers/net/wireless/ath/ath9k/eeprom.h > @@ -106,7 +106,7 @@ > #define AR9285_RDEXT_DEFAULT 0x1F > > #define ATH9K_POW_SM(_r, _s) (((_r) & 0x3f) << (_s)) > -#define FREQ2FBIN(x, y) ((y) ? ((x) - 2300) : (((x) - 4800) / 5)) > +#define FREQ2FBIN(x, y) (u8)((y) ? ((x) - 2300) : (((x) - 4800) / 5)) Maybe better to use: static inline u8 FREQ2FBIN(int x, int y) { if (y) return x - 2300; return (x - 4800) / 5; }