public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Hugues FRUCHET <hugues.fruchet@st.com>,
	Andy Whitcroft <apw@canonical.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v1] checkpatch: test missing initial blank line in block comment
Date: Fri, 07 Apr 2017 03:22:08 -0700	[thread overview]
Message-ID: <1491560528.3250.20.camel@perches.com> (raw)
In-Reply-To: <bb5eb3fe-f089-3961-731f-60e22392efb1@st.com>

On Fri, 2017-04-07 at 09:56 +0000, Hugues FRUCHET wrote:
> Hi Joe,

Hi again Hugues.

> here is the output with the last version of the script: 
> https://paste.ubuntu.com/24333124/
> 
> Differences are on the macro cases and the //foo \ *bar, no more warned.

Thanks.

I guess my only real concern about this test is
there are ~15000 instances of this in the tree.

Do maintainers care if comments are formatted

	/*
	 * [multiple...]
	 * line comment
	 */

vs

	/* [multiple...]
	 * line comment
	 */

enough to want others to submit patches
changing from the latter style?

The reason the networking checking exists is
because David Miller, the primary networking
maintainer, was constantly telling others to
resubmit patches to his preferred style.

I doubt there's another maintainer that cares
that much one way or another.

I don't.

Any opinions from anyone else?

      reply	other threads:[~2017-04-07 10:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-03  8:08 [PATCH v1] checkpatch: test missing initial blank line in block comment Hugues Fruchet
2017-04-03  8:08 ` Hugues Fruchet
2017-04-03 19:06   ` Joe Perches
2017-04-05  8:23     ` Hugues FRUCHET
2017-04-05  8:35       ` Joe Perches
2017-04-05  9:43         ` Hugues FRUCHET
2017-04-05  9:55           ` Joe Perches
2017-04-05 13:26             ` Hugues FRUCHET
2017-04-07  9:56               ` Hugues FRUCHET
2017-04-07 10:22                 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491560528.3250.20.camel@perches.com \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=hugues.fruchet@st.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox