linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Taeung Song <treeze.taeung@gmail.com>,
	Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>
Subject: [PATCH v2 2/5] perf annotate: Use stripped line instead of raw disassemble line
Date: Sat,  8 Apr 2017 09:52:25 +0900	[thread overview]
Message-ID: <1491612748-1605-3-git-send-email-treeze.taeung@gmail.com> (raw)
In-Reply-To: <1491612748-1605-1-git-send-email-treeze.taeung@gmail.com>

When parsing disassemble lines for source line number,
use a stripped line instead of raw line.

Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
 tools/perf/util/annotate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 5c9669f..9fdf263 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1151,8 +1151,8 @@ static int symbol__parse_objdump_line(struct symbol *sym, struct map *map,
 	parsed_line = rtrim(line);
 
 	/* /filename:linenr ? Save line number and ignore. */
-	if (regexec(&file_lineno, line, 2, match, 0) == 0) {
-		*line_nr = atoi(line + match[1].rm_so);
+	if (regexec(&file_lineno, parsed_line, 2, match, 0) == 0) {
+		*line_nr = atoi(parsed_line + match[1].rm_so);
 		return 0;
 	}
 
-- 
2.7.4

  parent reply	other threads:[~2017-04-08  0:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-08  0:52 [PATCH v2 0/5] Refactoring with ltrim() and rtrim() Taeung Song
2017-04-08  0:52 ` [PATCH v2 1/5] perf annotate: Refactor the code to parse disassemble lines with {l,r}trim() Taeung Song
2017-04-12  5:42   ` [tip:perf/core] " tip-bot for Taeung Song
2017-04-08  0:52 ` Taeung Song [this message]
2017-04-12  5:42   ` [tip:perf/core] perf annotate: Use stripped line instead of raw disassemble line tip-bot for Taeung Song
2017-04-08  0:52 ` [PATCH v2 3/5] perf ui browser: Refactor the code to parse color configs with ltrim() Taeung Song
2017-04-08  0:52 ` [PATCH v2 4/5] perf pmu: Refactor wordwrap() " Taeung Song
2017-04-08  0:52 ` [PATCH v2 5/5] perf tools: Refactor the code to strip command name with {l,r}trim() Taeung Song
2017-04-08 18:48   ` David Ahern
2017-04-09  5:36     ` Taeung Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491612748-1605-3-git-send-email-treeze.taeung@gmail.com \
    --to=treeze.taeung@gmail.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).