From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752747AbdDHOuk (ORCPT ); Sat, 8 Apr 2017 10:50:40 -0400 Received: from smtprelay0119.hostedemail.com ([216.40.44.119]:38473 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751841AbdDHOud (ORCPT ); Sat, 8 Apr 2017 10:50:33 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3876:3877:4321:4605:5007:6114:6642:7901:10004:10400:10848:11026:11657:11658:11914:12043:12048:12296:12740:12760:12895:13069:13255:13311:13357:13439:14659:14721:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: root71_3e75a6b09616 X-Filterd-Recvd-Size: 1677 Message-ID: <1491663025.3250.39.camel@perches.com> Subject: Re: [PATCH 2/3] IB/srp: Enclose 14 expressions for the sizeof operator by parentheses From: Joe Perches To: SF Markus Elfring , linux-rdma@vger.kernel.org, Bart Van Assche , Doug Ledford , Hal Rosenstock , Sean Hefty Cc: LKML , kernel-janitors@vger.kernel.org Date: Sat, 08 Apr 2017 07:50:25 -0700 In-Reply-To: References: <50db1f1d-b689-1a9d-f6dd-a0f55169c75a@users.sourceforge.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-04-08 at 14:12 +0200, SF Markus Elfring wrote: [] > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c [] > @@ -3308,7 +3308,7 @@ static ssize_t srp_create_target(struct device *dev, > target_host->max_channel = 0; > target_host->max_id = 1; > target_host->max_lun = -1LL; > - target_host->max_cmd_len = sizeof ((struct srp_cmd *) (void *) 0L)->cdb; > + target_host->max_cmd_len = sizeof(((struct srp_cmd *)(void *)0L)->cdb); Maybe better as: target_host->max_cmd_len = FIELD_SIZEOF(struct srp_cmd, cdb);