From: Martin Walch <walch.martin@web.de>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>, linux-kbuild@vger.kernel.org
Cc: "Dirk Gouders" <dirk@gouders.net>,
"Michal Marek" <mmarek@suse.cz>,
"Jiri Kosina" <trivial@kernel.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Benjamin Poirier" <bpoirier@suse.de>,
"Wang YanQing" <udknight@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jean Delvare" <jdelvare@suse.de>,
"Kees Cook" <keescook@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] kconfig: remove unused definition from scanner
Date: Thu, 03 Oct 2013 02:30:21 +0200 [thread overview]
Message-ID: <1491733.iNaKkFyqph@tacticalops> (raw)
In-Reply-To: <201310020857.54800.yann.morin.1998@free.fr>
On Wednesday 02 October 2013 08:57:54 Yann E. MORIN wrote:
> On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:
> > I think you should also regenerate the scanner and add
> > the new zconf.lex.c_shipped to this patch.
>
> I think sending the re-generated parser as a separate patch helps
> in reviewing. Ie. I'd prefer a fifth patch.
>
> BTW, regenerating the parser can be done with:
> make REGENERATE_PARSERS=1 config
Actually, I regenerated the scanner. However, the results did not change
after applying the patch, because the definition that the patch removes
(ws) is not used anywhere. It is only a cleanup.
Regenerating the scanner and the parser code with newer versions of
flex and bison results in code changes. However, they are not related to
the patch, but originate from updates in flex and bison.
Therefore I did not see any point in including the regenerated files in
this patch set.
Of course, if you see any benefit in regenerating the *_shipped files, I can
still do so.
Regards,
Martin Walch
--
next prev parent reply other threads:[~2013-10-03 0:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 5:24 [PATCH 4/4] kconfig: remove unused definition from scanner Martin Walch
2013-10-02 6:42 ` Dirk Gouders
2013-10-02 6:57 ` Yann E. MORIN
2013-10-03 0:30 ` Martin Walch [this message]
2013-10-03 6:37 ` Yann E. MORIN
2013-10-03 13:13 ` Dirk Gouders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491733.iNaKkFyqph@tacticalops \
--to=walch.martin@web.de \
--cc=akpm@linux-foundation.org \
--cc=arve@android.com \
--cc=bpoirier@suse.de \
--cc=dirk@gouders.net \
--cc=jdelvare@suse.de \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=trivial@kernel.org \
--cc=udknight@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox