From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752663AbdDJTgd (ORCPT ); Mon, 10 Apr 2017 15:36:33 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:33417 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751350AbdDJTgb (ORCPT ); Mon, 10 Apr 2017 15:36:31 -0400 Message-ID: <1491852986.2188.0.camel@gmail.com> Subject: Re: [PATCH] staging: wilc1000: use kernel define byte order macros From: perry To: Dan Carpenter Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, aditya.shankar@microchip.com, linux-kernel@vger.kernel.org, ganesh.krishna@microchip.com Date: Mon, 10 Apr 2017 15:36:26 -0400 In-Reply-To: <20170324085749.GQ32449@mwanda> References: <1490126140-12867-1-git-send-email-perry.hooker@gmail.com> <20170321201904.GD32449@mwanda> <1490132410.17318.6.camel@gmail.com> <20170322092403.GF32449@mwanda> <1490234008.66163.1.camel@gmail.com> <20170323083317.GM4343@mwanda> <1490307306.66163.8.camel@gmail.com> <20170324085749.GQ32449@mwanda> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, Can you clarify why the rx_buffer always holds little-endian data? It looks to me like this buffer is filled by wilc_sdio_cmd53(), which uses sdio_memcpy_toio(), which ultimately sets the data with sg_set_buf(). This function appears to use host-endian byte ordering. Regards, Perry On Fri, 2017-03-24 at 11:57 +0300, Dan Carpenter wrote: > On Thu, Mar 23, 2017 at 04:15:06PM -0600, Robert Perry Hooker wrote: > > Well, yes, all data is 'endian' one way or another, right? I guess the byte order of the tx/rx_buffers is host > > -endian > > (which could be big), or _maybe_ network-endian... > > The good news is this code is Open Source[tm] so we don't need to guess. > It's full of little endian data. > > regards, > dan carpenter >