* [PATCH 1/2] drivers/dax: Avoiding potential deadlock
@ 2017-04-11 5:24 Pushkar Jambhlekar
0 siblings, 0 replies; 5+ messages in thread
From: Pushkar Jambhlekar @ 2017-04-11 5:24 UTC (permalink / raw)
To: pushkar.iit; +Cc: linux-kernel
dax_dev_huge_fault returning without releasing lock. Making code change to avoid this situation
Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
--- a/drivers/dax/dax.c
+++ b/drivers/dax/dax.c
@@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
rc = __dax_dev_pud_fault(dax_dev, vmf);
break;
default:
- return VM_FAULT_FALLBACK;
+ rc = VM_FAULT_FALLBACK;
}
rcu_read_unlock();
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 1/2] drivers/dax: Avoiding potential deadlock
[not found] <Dave Jiang <dave.jiang@intel.com>
@ 2017-04-11 5:26 ` Pushkar Jambhlekar
0 siblings, 0 replies; 5+ messages in thread
From: Pushkar Jambhlekar @ 2017-04-11 5:26 UTC (permalink / raw)
To: Dan Williams; +Cc: linux-kernel, Pushkar Jambhlekar
dax_dev_huge_fault returning without releasing lock. Making code change to avoid this situation
Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
--- a/drivers/dax/dax.c
+++ b/drivers/dax/dax.c
@@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
rc = __dax_dev_pud_fault(dax_dev, vmf);
break;
default:
- return VM_FAULT_FALLBACK;
+ rc = VM_FAULT_FALLBACK;
}
rcu_read_unlock();
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 1/2] drivers/dax: Avoiding potential deadlock
@ 2017-04-11 5:26 Pushkar Jambhlekar
2017-04-11 16:17 ` Dan Williams
0 siblings, 1 reply; 5+ messages in thread
From: Pushkar Jambhlekar @ 2017-04-11 5:26 UTC (permalink / raw)
To: Dan Williams, Dave Jiang, Andrew Morton, Johannes Thumshirn,
Ross Zwisler
Cc: linux-kernel, Pushkar Jambhlekar
dax_dev_huge_fault returning without releasing lock. Making code change to avoid this situation
Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
--- a/drivers/dax/dax.c
+++ b/drivers/dax/dax.c
@@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
rc = __dax_dev_pud_fault(dax_dev, vmf);
break;
default:
- return VM_FAULT_FALLBACK;
+ rc = VM_FAULT_FALLBACK;
}
rcu_read_unlock();
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] drivers/dax: Avoiding potential deadlock
2017-04-11 5:26 Pushkar Jambhlekar
@ 2017-04-11 16:17 ` Dan Williams
2017-04-12 4:19 ` Pushkar Jambhlekar
0 siblings, 1 reply; 5+ messages in thread
From: Dan Williams @ 2017-04-11 16:17 UTC (permalink / raw)
To: Pushkar Jambhlekar
Cc: Dave Jiang, Andrew Morton, Johannes Thumshirn, Ross Zwisler,
linux-kernel@vger.kernel.org
On Mon, Apr 10, 2017 at 10:26 PM, Pushkar Jambhlekar
<pushkar.iit@gmail.com> wrote:
> dax_dev_huge_fault returning without releasing lock. Making code change to avoid this situation
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/dax/dax.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
> index 0d1ca24..fd9c4db 100644
> --- a/drivers/dax/dax.c
> +++ b/drivers/dax/dax.c
> @@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
> rc = __dax_dev_pud_fault(dax_dev, vmf);
> break;
> default:
> - return VM_FAULT_FALLBACK;
> + rc = VM_FAULT_FALLBACK;
> }
> rcu_read_unlock();
Thanks Pushkar, I'll apply this and combine with patch 2 as well.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] drivers/dax: Avoiding potential deadlock
2017-04-11 16:17 ` Dan Williams
@ 2017-04-12 4:19 ` Pushkar Jambhlekar
0 siblings, 0 replies; 5+ messages in thread
From: Pushkar Jambhlekar @ 2017-04-12 4:19 UTC (permalink / raw)
To: Dan Williams
Cc: Dave Jiang, Andrew Morton, Johannes Thumshirn, Ross Zwisler,
linux-kernel@vger.kernel.org
Thanks Dan!
On Tue, Apr 11, 2017 at 9:47 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Mon, Apr 10, 2017 at 10:26 PM, Pushkar Jambhlekar
> <pushkar.iit@gmail.com> wrote:
>> dax_dev_huge_fault returning without releasing lock. Making code change to avoid this situation
>>
>> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
>> ---
>> drivers/dax/dax.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
>> index 0d1ca24..fd9c4db 100644
>> --- a/drivers/dax/dax.c
>> +++ b/drivers/dax/dax.c
>> @@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
>> rc = __dax_dev_pud_fault(dax_dev, vmf);
>> break;
>> default:
>> - return VM_FAULT_FALLBACK;
>> + rc = VM_FAULT_FALLBACK;
>> }
>> rcu_read_unlock();
>
> Thanks Pushkar, I'll apply this and combine with patch 2 as well.
--
Jambhlekar Pushkar Arun
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-12 4:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-11 5:24 [PATCH 1/2] drivers/dax: Avoiding potential deadlock Pushkar Jambhlekar
[not found] <Dave Jiang <dave.jiang@intel.com>
2017-04-11 5:26 ` Pushkar Jambhlekar
-- strict thread matches above, loose matches on Subject: below --
2017-04-11 5:26 Pushkar Jambhlekar
2017-04-11 16:17 ` Dan Williams
2017-04-12 4:19 ` Pushkar Jambhlekar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox