Re: [PATCH 1/2] drivers/dax: Avoiding potential deadlock

Dan Williams
2017-04-11T16:17:08Z

On Mon, Apr 10, 2017 at 10:26 PM, Pushkar Jambhlekar
<pushkar.iit@gmail.com> wrote:
> dax_dev_huge_fault returning without releasing lock. Making code change to avoid this situation
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/dax/dax.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
> index 0d1ca24..fd9c4db 100644
> --- a/drivers/dax/dax.c
> +++ b/drivers/dax/dax.c
> @@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
> rc = __dax_dev_pud_fault(dax_dev, vmf);
> break;
> default:
> - return VM_FAULT_FALLBACK;
> + rc = VM_FAULT_FALLBACK;
> }
> rcu_read_unlock();

Thanks Pushkar, I'll apply this and combine with patch 2 as well.