From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753964AbdDKIQ7 (ORCPT ); Tue, 11 Apr 2017 04:16:59 -0400 Received: from mail-bn3nam01on0047.outbound.protection.outlook.com ([104.47.33.47]:6064 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752537AbdDKIQc (ORCPT ); Tue, 11 Apr 2017 04:16:32 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; Message-ID: <1491898583.26722.2.camel@nxp.com> Subject: Re: [PATCH v2 2/4] cpufreq: imx6q: Set max suspend_freq to avoid changes during suspend From: Leonard Crestez To: Viresh Kumar , Lucas Stach CC: "Rafael J. Wysocki" , Sascha Hauer , Shawn Guo , Mark Brown , Robin Gong , Anson Huang , Irina Tirdea , Fabio Estevam , Octavian Purdila , "Liam Girdwood" , , , Date: Tue, 11 Apr 2017 11:16:23 +0300 In-Reply-To: <20170411063738.GE3670@vireshk-i7> References: <5f61b819733127ddc7d41e82bf703a355c845b49.1491324640.git.leonard.crestez@nxp.com> <20170411063738.GE3670@vireshk-i7> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131363721898966540;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39840400002)(39450400003)(39380400002)(39410400002)(39850400002)(39400400002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(24454002)(377424004)(9170700003)(23676002)(4326008)(54906002)(50466002)(15650500001)(104016004)(85426001)(2950100002)(229853002)(230700001)(77096006)(53546009)(103116003)(5820100001)(38730400002)(356003)(6246003)(39060400002)(36756003)(53936002)(5660300001)(305945005)(189998001)(50986999)(47776003)(8936002)(50226002)(33646002)(76176999)(8656002)(81166006)(105606002)(2906002)(106466001)(7416002)(86362001)(57986006)(8676002)(99106002)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:CO2PR03MB2278;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD051;1:4SXj4IZu4AXCJKZmQIcSSZ2IboT9p9HbrTA8Hae6HQaut1BjcvRvk1Zc0/JTPXDuP3wDZOPIO0uc/LRHGX1kJy5AuSH/qJzv+dCI3fvjN1gmIDR9GKRYroK/xvs9hQX3tplTRw+uC8E4KnPi4nqleQeR2dccPvh57/AokmkAxh8GIZy+b4Ity6Yb6tNv/xkFrBFm4Ij6rLfJDV5YQxv2wdNog3RHGzYBmd/9ijnShtdK/Y6uCi2Vaq19Uai+DdNguc7hQqjoflKp/CoP6tiMVR+32gCF/XevkaU+nFETHENpn5LauNn4emPn2m8gIRCDDt9lp7h5fH4QmGSoUd9vqXm+Th6nGSTnPnnTgWyFZOyGPp37ItfRRbYtvx2vb/pwgDBXiaCim3rkzoWqryQctavUIHufmOLbwUiN9zXAs9s/XiVZHt8VlHBF3yNaNc3yfMA9Vz14DaixS0pemhchQivFKeMzXcR3aSyK6hWWLQrDKGsqk3MLcxzmLtTlVHDrWJjtseaWYE5WDklXDLTVvAo2nIoWPOVCK9U9ah/Lv3XfijlxAsBPQaZOSfdMCiGYdmMDv6cgAZA4UMPpuS6TnSvWeh7YkjFeRaf/MPRYCn7u3oKXbZ96sWXW0C3f5jOL X-MS-Office365-Filtering-Correlation-Id: fccb0af8-cc17-48e9-dcae-08d480b30e9d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:CO2PR03MB2278; X-Microsoft-Exchange-Diagnostics: 1;CO2PR03MB2278;3:+smVm5s+TIluSEYtBGmrVoeCO+N9bf97YkU2s909DJnUmvuVvvBFD/yJBZ/yxpFWRTMSNC4CZxKjtwGL8LPN6VvJch/GTxzLQqy9q0HzzYoi3jrwWsOUQFJkdJTtJrCCADYMcsEB2TAGvuNOET4frzYviesNO0utzOmUgAfU4Ottg0E76ZJOPhS8vTzGny885xu+dVzHYyh6Relg3wUVMKFSzgZhYzCtPGTsCWMlLn6o58OyyZTpL7XZhHBLVzFVyGXIzaAWBs20hrbo2FgGPy20cXTZMoSVypnhsGVdK+7d0Rmkm5Xh9gn/AObMCWBULtBH//L7rH9fD2r9MiZM/Ny+A1Vp4iEtI19hYG7UXYgmQJrPEs0gtbZY5EYH4IHJvLRDU2ekI4XtwzY4jeIGIgwlbpvD5FMae95iQuQMuxz1Y9ELNnSLhZiS0Jzy5Er7;25:KMBQmfLpmzSiWtYb9TuhcGpeaahxiZ0Pa6JIeB63h8ObEr5w7wZu5wkS1GiLLNbZZ1oqejeVs129yW/D34bM3QdrJRu2jgBqSOp7JE6eo1tmplIqpK/JNQOZI1V+RuM7xylLZMzGDrfVvdiXA4hV1G35dXTM+dV+kSUFRCnoV37BtzXLBiUS7sAnlxb1c1NElFPVggbXDdewhtU+ulCH1LVmWcJNCf1q6Sfk7UNvkAtnyrWwOcJOTHDEu+o89Qoq3ymAq92VutsXVOEBJVjr/vyrzs2KPNHh23gvJR2lyGsnWTtdgRzzTLNU1uLnsygXIVOyhjNIDLWYEsT3FiHReEQOGWSa6aCSQAeD4tNVZBc5GbgaJ1652ExKtLzJZbn/NF2NPygsWbkx9gAEvN4o1fX8B3pG3AC9hto/cOBv4Fm+vT2VWpIqlrMi1e5dlNBahuYp62NPRZ1+bTe9XyQCHg== X-Microsoft-Exchange-Diagnostics: 1;CO2PR03MB2278;31:VuS5tB5Xam7TskZZKKv8OBlxfs75tU05zPqE9YqClL1flTDqQFIqV+gf3NtKSanTUEQpRJuPEZyu8j4M3EZvGSXR9aBQXLn7vkdeER5diufVSYqpqp3slYjWA9lr4G6AvIHSNH6Yem1dEcP/yRm9SNwvGa5/ovmQb/f/+TiN/G/cscF6VtOR0RPvbhP9q2ktgvFxhWT1sqPjwD00F4V8F9hEEO7gUNwFgJ3w1r91JiSgoXOI3sHAt2crlE5ICAMVscK5Xled9mIQyFN9x+6BaA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(13017025)(13024025)(13023025)(13018025)(8121501046)(13015025)(5005006)(10201501046)(93006095)(93001095)(3002001)(6055026)(6096035)(201703131430075)(201703131448075)(201703131433075)(201703161259075)(20161123556025)(20161123561025)(20161123563025)(20161123565025);SRVR:CO2PR03MB2278;BCL:0;PCL:0;RULEID:(400006);SRVR:CO2PR03MB2278; X-Microsoft-Exchange-Diagnostics: 1;CO2PR03MB2278;4:AhiGWLhg4UCTotiWguWEAJk9Bt4ViFdvxsxUHnKE1djrAljX4EUarwJ9EY1AItdD2J4iVXik5UhI0N9QCshLcHMOAbxuwqh9nyFYi9AD2gGZW9bthN3Pg5zlY00Ue4UUa3Uc71AuBMDXa08YoB0zW7O5oDpxOi37PBvdlijDEVvZZRhiN7+Zpo7PRpc2n3P4UPc7QbtFFONEy+KCk0LE3MuT7vGhXoafkHU2SM30c1qWoYyTToxCUKwmPmmBCznKJqjow2sDJ/t0hUw5uN+aBg1W+zJwU+fdUAu426K6soTymf08IbVilyBLidu3PlGzGg3+kC5zBWdFFSOzfCj6VEgF5Gb4UL0NeOUZ21db5IYQbbpAXhld2UoeiZzYHRJFsO70U9c51ltU8mmiQAPE/Cf42jkZaOLHH3JI6LLYg4HcrOv++3V9CSyVojSxWpUd/EUjxfe61ZdTVNLQ9oDG1AzVn4Owl+Y4q9y/IM9M2qCJ6rxFY+xFXtMrYLJnM+C+3lJiGcLxU8lkFo+4xA+Y4/6oyf6wmo6d/oaKSP9DKeSe2/oE77J9u8xaUoSeQj5VOldiFWx5GMH7NyESpzW4w7EtYrtzRAPlxwJGBF5XDWW6k3OZ+C14LeZwiglpK+lgkgclg9f7oBgpdtEZNdz+zVbRr+kKVkZP9+msG9JdYmQCboCc+mfCwQRhfGpa1K8Gnga5D0Loz8aHnb4aazauOazgJmbDc6O3FwCZZeT0BePkMY/HkrpgHAgmZePyx+ImVQ1ZSVa/Ff+VTSDmmB4uYLyaWQR2ZNTIR9HdDQKzMClQWSw3TO9CHRanN450EL6m30p6wCMwQ8xNitQjP6VHhVZfy6tiHdclhI3nrwQzrygqSVGMB2Gt/84ZoRP6/N5QJXffAz2nbt39dNnncdxNdQ== X-Forefront-PRVS: 0274272F87 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjAzTUIyMjc4OzIzOlZLaUVGSW5lSE9OdlpTRlRqb0pFZ2FvZDdh?= =?utf-8?B?bStIVnJwU0kxV0N0TGIvcENWTzBDaVEyUG5TdEJUTnhHV2NxVkc3UzB4L3hk?= =?utf-8?B?dmVsQzV6ckZjKzNCRnBrZFFWRm9iT2xxOG9ZMUxkTnJxcmpaRTE0eTNIV1py?= =?utf-8?B?c1QxcGJJUnVLbmlWdmNlKzNsTGFOSFVKZUtTb0FFRUE3Rkhtb2dhTnRaOVpC?= =?utf-8?B?dm91Y002WTBZV3BzNlRRU1dDcnVRQmVyblVkanl5MHhyS0VaNjdzK01FZTFv?= =?utf-8?B?SEVwY213ME8xM2xtZ3NUZ01xTjcybDNQTERPTW5Rd3hIQTNnKzZ5cklYZlJB?= =?utf-8?B?czROZURQU0k3OHR4YlVOMHJnV2V2TzNBZlp1VFpBSUIzalN4aFhINXR3RUtk?= =?utf-8?B?RkpaelFSNnphTEczZjRlbEtVd2RxT2g2SU5SOGxOWld5Nys2bUZsU0dhYWJ6?= =?utf-8?B?U0VuQytpQjBMMGZNaDdvaUd0dmxtdTFEOWxjVi85SW1ES050UUZxeU1QeFJm?= =?utf-8?B?cGRramZ0ZjVMOW9peGt6b3dLTUFFbThmaTRZZlZXZUNFT2EyQjZGa2psaENw?= =?utf-8?B?MWYxQ01VUU5NclFmNU9iV2FXWVE5WEloazYrZ0kzNm1iMStIMlI0dUlkREpt?= =?utf-8?B?QW9ici8xZjdMa1NmczNxbXVPb1d6YytuTkRIRmZuVVF3c2VyNmhZaEkwV0FR?= =?utf-8?B?dzRJL0NvMDhzVnZCM2ZNT0JSL21wUHJzQ3FUNkplZ1Z1ZXFMVmxuWHdYTlRO?= =?utf-8?B?RTlmbndLWVpIazlBbll4Z1JicG91dlVlbVlWaUxjaVZPKzErMUlzeTVCczBy?= =?utf-8?B?Um1pUVJORjBMV3BxTUtmSDM3RXErY2g1TVM0RlAzTHZWc2k5dG82YjEybmFt?= =?utf-8?B?cCt1NEx2eE0raVp0N2ZnTTVLeEk2UlRYdW9UWk4xbGM4SFVacXhwa1c4ZWxz?= =?utf-8?B?d0JSbmJKNGVsSWtWRXhYdmNaMytmQ1lGSFdoL2ZmdGRpUHFmNEVEUzRCVTM0?= =?utf-8?B?YzhyYTlxbTJWbUM3WDYvSDRqVk9XblNWWXRUWURPYUZPMjRRT28weWxuMGN5?= =?utf-8?B?RklCc2cxTHVkVjdQQWNMNkE3U1puUDcvZmp4ZDlvZXplbFFWRzNyS05WYmcz?= =?utf-8?B?ZDhLSzk1a0xITG1ZQkJNeXNGTnBCS1RQTEp0TldrM2NsQkVVaVIvV0hYUzVw?= =?utf-8?B?SXRKdnkwR0Y2Nkw1WXFYeXU1cnBBc3hxb1o4cU5jZkpsd2lnaUZCL1UvdFBP?= =?utf-8?B?ZWs2cFV1SFdiQ3N2Wlg0aE9HOVlOOW5TQjRLTXBDTW1pQzVHK1k5YXgxdlZ0?= =?utf-8?B?eGs3VlF0NGtUMmlJcmljTHJvM2xhRXdnNHo5aUx2d2JPS1JQamNOb01JOFJi?= =?utf-8?B?RFBNK0VIK1RRRG8xRlFiVFRQQy8rRFJzai9qYnRBT2FEKzV0S0dhYndtMENw?= =?utf-8?B?YksyVkFaSklkbUY3OXVoUUk3OGF5WDRnSUNJdUpKNEg5cGdMTnVHTThjYmV0?= =?utf-8?B?bXBPcUZmYm11cUVBQWdRVVdLVnJNNncybWtPMWM0cFhjRysxSWdhRTdFbDVJ?= =?utf-8?B?ZkN5d0pWMEZxUDFEbUU1a2FzS3k4TTZzVTR3S0s0V0RwTFR5QkEybm9ZR1NJ?= =?utf-8?B?RVR4QXJKc1hYWkdkUjNnaEpRSHhBSG03bU45T1RkTWp2Q1JSemttTFN6ZTIw?= =?utf-8?B?T2tybTgyLytlNmZxTVBPSGljZlYrdVo0bWxGY2VHZHh2RVNKakFBcW1lNUF4?= =?utf-8?B?VEEwL2hpcS9scDNtemRiRjhwWHhWd2lTb215YzFyOGdrVjY2UjI4cHUwYTBL?= =?utf-8?B?Nml5bEtwa0dIVjN1dUQ0ODRDcjZneEt1TmVpUlkrWTBSZkhKczlYMEhzMFpL?= =?utf-8?Q?EtESjPJEcGfwniNKieXBvN0PhU/CtSf3?= X-Microsoft-Exchange-Diagnostics: 1;CO2PR03MB2278;6:PRGPl132O6kQUtuSES+QwPP36TH2dkGwrabI/vRvlkWZjkl3LtJfws4i0Beb7zCWu4hEIJO8UO6zrXVXo0wzVYdw02R0mXO3rk1tlB+zGd5tHsYLnH9nv0iJMbiO2GudQNPHH2tS3TLdC3jNCWsxSXgJive593D+1IwwvXxQnVU7KgXGWbIdiE3xPHzBpaX2wziQK+GCenH5XLCJvD/fy9d6QNNODlnRiPG3u1BePujF0O5UhhRJlK8x/4yj8ZC2ubUHX+DzNkarAm8SZjy6Vo1psCJcAspT7Q0W6R1BMazKWyejea0FQniY7XdNt/JMFxyxiDj29VUGKrXEEgUls8GU2OnmRkwC9iXEpSa1eDHm2NywEPnVAJGJ1wcEfx4XmVQkPEW4nuD9LibLWEB8ZoMOvw4axqojnPEMs+sjEGZowpVsgCNoqlEDuR7viAhLMj9GKqco2UtllyM6wgTAEQ==;5:4g6gkQ7mfgVEZLQ2voDj9x8mhrZeJ7tK/Bmebt+ljNI34xOaeCuXfXU18ryqYUsDAn50axxQFB7+icUY+gmHLg746KK3Mbixp2IrnoHLTWUk0NO6eSt915ZvixQsK923A+jT7aKiGt+Q5/nt74lB6Y/xaOrXELgjD6IBvoqhu084LEnpUyXMsPwwIoD/iUeO;24:81H95mL5joT5EaW8KTfgPkJEp4nR0XvFDz3I7SR/kLchjQROhfZ964BveSt4J52pIuf1fbrP/RXGjkyJszIbZrUJ3h0gGMI0DMlVagi+yTc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO2PR03MB2278;7:woDMFN12LtwHGMxX0rIKG5IQPRk05DpvB5O8wRE+ptYC9+Ctvo73wPsJiJvtcUqHJe7F8SPTcU1gEfWNx6M9NnCwrc9+DyZhi6cuRLTMrv0jRjXo2uoEGs6kxCDWWT/ZNpti5kkGkEcUd37fugHjFAXgW19N3NBrrQpix1rr/9Rw9tq9FJXqTSLMcNoEmeqLWMlTuN8e7J0CasB06wdVp14amZzgt++WEZBORg8IwHLbpaSrpeiEKL69AuYccq4iOUtmW0Yzd0HMNOWJrthJICbA5Wav5MauSSrHdkTIqGvHX3i/PYeAZDbrRmdTFyCTG6B0a5XjUEJ4AX6ShbmV2A== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2017 08:16:29.4598 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2278 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-04-11 at 12:07 +0530, Viresh Kumar wrote: > On 04-04-17, 20:04, Leonard Crestez wrote: > > If the cpufreq driver tries to modify voltage/freq during suspend/resume > > it might need to control an external PMIC via I2C or SPI but those > > devices might be already suspended. This issue is likely to happen > > whenever the LDOs have their vin-supply set. > > > > To avoid this scenario we just increase cpufreq to the maximum before > > suspend. > > > > Signed-off-by: Leonard Crestez > > --- > > drivers/cpufreq/imx6q-cpufreq.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > I have already Acked this earlier, why didn't you add it ? Because v2 is different based on comments from Lucas. It didn't seem appropriate to keep an old "Acked-by" in this case.