Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder (fwd)

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder (fwd)
@ 2017-04-03  6:00 ` Julia Lawall
  2017-04-03  6:17   ` Smitha T Murthy
  0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2017-04-03  6:00 UTC (permalink / raw)
  To: Smitha T Murthy
  Cc: kyungmin.park, kamil, jtp.park, a.hajda, mchehab, pankaj.dubey,
	krzk, m.szyprowski, s.nawrocki, linux-arm-kernel, linux-media,
	linux-kernel, kbuild-all

See line 2101

julia

--------- Forwarded message ----------
Date: Mon, 3 Apr 2017 05:04:39 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder

Hi Smitha,

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.11-rc4 next-20170331]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Smitha-T-Murthy/Add-MFC-v10-10-support/20170403-033620
base:   git://linuxtv.org/media_tree.git master
:::::: branch date: 88 minutes ago
:::::: commit date: 88 minutes ago

>> drivers/media/platform/s5p-mfc/s5p_mfc_enc.c:2101:6-25: WARNING: Unsigned expression compared with zero: p -> codec . hevc . level < 0

git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout bca072db65317d79554527391338ce8bc6fbde58
vim +2101 drivers/media/platform/s5p-mfc/s5p_mfc_enc.c

bca072db Smitha T Murthy 2017-03-31  2085  		break;
bca072db Smitha T Murthy 2017-03-31  2086  	case V4L2_CID_MPEG_VIDEO_HEVC_B_FRAME_QP:
bca072db Smitha T Murthy 2017-03-31  2087  		p->codec.hevc.rc_b_frame_qp = ctrl->val;
bca072db Smitha T Murthy 2017-03-31  2088  		break;
bca072db Smitha T Murthy 2017-03-31  2089  	case V4L2_CID_MPEG_VIDEO_HEVC_FRAME_RATE_RESOLUTION:
bca072db Smitha T Murthy 2017-03-31  2090  		p->codec.hevc.rc_framerate = ctrl->val;
bca072db Smitha T Murthy 2017-03-31  2091  		break;
bca072db Smitha T Murthy 2017-03-31  2092  	case V4L2_CID_MPEG_VIDEO_HEVC_MIN_QP:
bca072db Smitha T Murthy 2017-03-31  2093  		p->codec.hevc.rc_min_qp = ctrl->val;
bca072db Smitha T Murthy 2017-03-31  2094  		break;
bca072db Smitha T Murthy 2017-03-31  2095  	case V4L2_CID_MPEG_VIDEO_HEVC_MAX_QP:
bca072db Smitha T Murthy 2017-03-31  2096  		p->codec.hevc.rc_max_qp = ctrl->val;
bca072db Smitha T Murthy 2017-03-31  2097  		break;
bca072db Smitha T Murthy 2017-03-31  2098  	case V4L2_CID_MPEG_VIDEO_HEVC_LEVEL:
bca072db Smitha T Murthy 2017-03-31  2099  		p->codec.hevc.level_v4l2 = ctrl->val;
bca072db Smitha T Murthy 2017-03-31  2100  		p->codec.hevc.level = hevc_level(ctrl->val);
bca072db Smitha T Murthy 2017-03-31 @2101  		if (p->codec.hevc.level < 0) {
bca072db Smitha T Murthy 2017-03-31  2102  			mfc_err("Level number is wrong\n");
bca072db Smitha T Murthy 2017-03-31  2103  			ret = p->codec.hevc.level;
bca072db Smitha T Murthy 2017-03-31  2104  		}
bca072db Smitha T Murthy 2017-03-31  2105  		break;
bca072db Smitha T Murthy 2017-03-31  2106  	case V4L2_CID_MPEG_VIDEO_HEVC_PROFILE:
bca072db Smitha T Murthy 2017-03-31  2107  		switch (ctrl->val) {
bca072db Smitha T Murthy 2017-03-31  2108  		case V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN:
bca072db Smitha T Murthy 2017-03-31  2109  			ctrl->val = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder (fwd)
  2017-04-03  6:00 ` [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder (fwd) Julia Lawall
@ 2017-04-03  6:17   ` Smitha T Murthy
  2017-04-11  9:00     ` Sylwester Nawrocki
  0 siblings, 1 reply; 6+ messages in thread
From: Smitha T Murthy @ 2017-04-03  6:17 UTC (permalink / raw)
  To: Julia Lawall
  Cc: kyungmin.park, kamil, jtp.park, a.hajda, mchehab, pankaj.dubey,
	krzk, m.szyprowski, s.nawrocki, linux-arm-kernel, linux-media,
	linux-kernel, kbuild-all

On Mon, 2017-04-03 at 08:00 +0200, Julia Lawall wrote:
> See line 2101
> 
> julia
> 
Thank you for bringing it to my notice, I had not checked on this git.
I will upload the next version of patches soon corresponding to this
git.

Thanks,
Smitha
> --------- Forwarded message ----------
> Date: Mon, 3 Apr 2017 05:04:39 +0800
> From: kbuild test robot <fengguang.wu@intel.com>
> To: kbuild@01.org
> Cc: Julia Lawall <julia.lawall@lip6.fr>
> Subject: Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder
> 
> Hi Smitha,
> 
> [auto build test WARNING on linuxtv-media/master]
> [also build test WARNING on v4.11-rc4 next-20170331]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Smitha-T-Murthy/Add-MFC-v10-10-support/20170403-033620
> base:   git://linuxtv.org/media_tree.git master
> :::::: branch date: 88 minutes ago
> :::::: commit date: 88 minutes ago
> 
> >> drivers/media/platform/s5p-mfc/s5p_mfc_enc.c:2101:6-25: WARNING: Unsigned expression compared with zero: p -> codec . hevc . level < 0
> 
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout bca072db65317d79554527391338ce8bc6fbde58
> vim +2101 drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> 
> bca072db Smitha T Murthy 2017-03-31  2085  		break;
> bca072db Smitha T Murthy 2017-03-31  2086  	case V4L2_CID_MPEG_VIDEO_HEVC_B_FRAME_QP:
> bca072db Smitha T Murthy 2017-03-31  2087  		p->codec.hevc.rc_b_frame_qp = ctrl->val;
> bca072db Smitha T Murthy 2017-03-31  2088  		break;
> bca072db Smitha T Murthy 2017-03-31  2089  	case V4L2_CID_MPEG_VIDEO_HEVC_FRAME_RATE_RESOLUTION:
> bca072db Smitha T Murthy 2017-03-31  2090  		p->codec.hevc.rc_framerate = ctrl->val;
> bca072db Smitha T Murthy 2017-03-31  2091  		break;
> bca072db Smitha T Murthy 2017-03-31  2092  	case V4L2_CID_MPEG_VIDEO_HEVC_MIN_QP:
> bca072db Smitha T Murthy 2017-03-31  2093  		p->codec.hevc.rc_min_qp = ctrl->val;
> bca072db Smitha T Murthy 2017-03-31  2094  		break;
> bca072db Smitha T Murthy 2017-03-31  2095  	case V4L2_CID_MPEG_VIDEO_HEVC_MAX_QP:
> bca072db Smitha T Murthy 2017-03-31  2096  		p->codec.hevc.rc_max_qp = ctrl->val;
> bca072db Smitha T Murthy 2017-03-31  2097  		break;
> bca072db Smitha T Murthy 2017-03-31  2098  	case V4L2_CID_MPEG_VIDEO_HEVC_LEVEL:
> bca072db Smitha T Murthy 2017-03-31  2099  		p->codec.hevc.level_v4l2 = ctrl->val;
> bca072db Smitha T Murthy 2017-03-31  2100  		p->codec.hevc.level = hevc_level(ctrl->val);
> bca072db Smitha T Murthy 2017-03-31 @2101  		if (p->codec.hevc.level < 0) {
> bca072db Smitha T Murthy 2017-03-31  2102  			mfc_err("Level number is wrong\n");
> bca072db Smitha T Murthy 2017-03-31  2103  			ret = p->codec.hevc.level;
> bca072db Smitha T Murthy 2017-03-31  2104  		}
> bca072db Smitha T Murthy 2017-03-31  2105  		break;
> bca072db Smitha T Murthy 2017-03-31  2106  	case V4L2_CID_MPEG_VIDEO_HEVC_PROFILE:
> bca072db Smitha T Murthy 2017-03-31  2107  		switch (ctrl->val) {
> bca072db Smitha T Murthy 2017-03-31  2108  		case V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN:
> bca072db Smitha T Murthy 2017-03-31  2109  			ctrl->val = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN;
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder (fwd)
  2017-04-03  6:17   ` Smitha T Murthy
@ 2017-04-11  9:00     ` Sylwester Nawrocki
  2017-04-11  9:23       ` Julia Lawall
  2017-04-11 11:26       ` Smitha T Murthy
  0 siblings, 2 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2017-04-11  9:00 UTC (permalink / raw)
  To: Smitha T Murthy, Julia Lawall
  Cc: kyungmin.park, kamil, jtp.park, a.hajda, mchehab, pankaj.dubey,
	krzk, m.szyprowski, linux-arm-kernel, linux-media, linux-kernel,
	kbuild-all

Hi,

On 04/03/2017 08:17 AM, Smitha T Murthy wrote:
> On Mon, 2017-04-03 at 08:00 +0200, Julia Lawall wrote:
>> See line 2101
>>
>> julia
>>
> Thank you for bringing it to my notice, I had not checked on this git.
> I will upload the next version of patches soon corresponding to this
> git.

In general please use the media master branch as a base for your patches
(git://linuxtv.org/media_tree.git master). Or latest branch in my
git repository, currently it's "for-v4.12/media/next-2" as can be seen
here: https://git.linuxtv.org/snawrocki/samsung.git

-- 
Thanks,
Sylwester

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder (fwd)
  2017-04-11  9:00     ` Sylwester Nawrocki
@ 2017-04-11  9:23       ` Julia Lawall
  2017-04-11  9:51         ` Sylwester Nawrocki
  2017-04-11 11:26       ` Smitha T Murthy
  1 sibling, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2017-04-11  9:23 UTC (permalink / raw)
  To: Sylwester Nawrocki
  Cc: Smitha T Murthy, Julia Lawall, kyungmin.park, kamil, jtp.park,
	a.hajda, mchehab, pankaj.dubey, krzk, m.szyprowski,
	linux-arm-kernel, linux-media, linux-kernel, kbuild-all



On Tue, 11 Apr 2017, Sylwester Nawrocki wrote:

> Hi,
>
> On 04/03/2017 08:17 AM, Smitha T Murthy wrote:
> > On Mon, 2017-04-03 at 08:00 +0200, Julia Lawall wrote:
> > > See line 2101
> > >
> > > julia
> > >
> > Thank you for bringing it to my notice, I had not checked on this git.
> > I will upload the next version of patches soon corresponding to this
> > git.
>
> In general please use the media master branch as a base for your patches
> (git://linuxtv.org/media_tree.git master). Or latest branch in my
> git repository, currently it's "for-v4.12/media/next-2" as can be seen
> here: https://git.linuxtv.org/snawrocki/samsung.git

I'm not making the patch.  It comes to me from kbuild.  If you would
prefer some tree not to be included, you can notify Fengguang about this:

fengguang.wu@intel.com

julia

>
> --
> Thanks,
> Sylwester
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder (fwd)
  2017-04-11  9:23       ` Julia Lawall
@ 2017-04-11  9:51         ` Sylwester Nawrocki
  0 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2017-04-11  9:51 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Smitha T Murthy, kyungmin.park, kamil, jtp.park, a.hajda, mchehab,
	pankaj.dubey, krzk, m.szyprowski, linux-arm-kernel, linux-media,
	linux-kernel, kbuild-all

On 04/11/2017 11:23 AM, Julia Lawall wrote:
> On Tue, 11 Apr 2017, Sylwester Nawrocki wrote:
>> Hi,
>>
>> On 04/03/2017 08:17 AM, Smitha T Murthy wrote:
>>> On Mon, 2017-04-03 at 08:00 +0200, Julia Lawall wrote:
>>>> See line 2101
>>>>
>>>> julia
>>>>
>>> Thank you for bringing it to my notice, I had not checked on this git.
>>> I will upload the next version of patches soon corresponding to this
>>> git.
>> In general please use the media master branch as a base for your patches
>> (git://linuxtv.org/media_tree.git master). Or latest branch in my
>> git repository, currently it's "for-v4.12/media/next-2" as can be seen
>> here: https://git.linuxtv.org/snawrocki/samsung.git
 >
> I'm not making the patch.  It comes to me from kbuild.  If you would
> prefer some tree not to be included, you can notify Fengguang about this:

Oops, my message was addressed to Smitha only, apologies for the confusion.
kbuild works fine. Thank you for your efforts.

-- 
Regards,
Sylwester

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder (fwd)
  2017-04-11  9:00     ` Sylwester Nawrocki
  2017-04-11  9:23       ` Julia Lawall
@ 2017-04-11 11:26       ` Smitha T Murthy
  1 sibling, 0 replies; 6+ messages in thread
From: Smitha T Murthy @ 2017-04-11 11:26 UTC (permalink / raw)
  To: Sylwester Nawrocki
  Cc: Julia Lawall, kyungmin.park, kamil, jtp.park, a.hajda, mchehab,
	pankaj.dubey, krzk, m.szyprowski, linux-arm-kernel, linux-media,
	linux-kernel, kbuild-all

On Tue, 2017-04-11 at 11:00 +0200, Sylwester Nawrocki wrote:
> Hi,
> 
> On 04/03/2017 08:17 AM, Smitha T Murthy wrote:
> > On Mon, 2017-04-03 at 08:00 +0200, Julia Lawall wrote:
> >> See line 2101
> >>
> >> julia
> >>
> > Thank you for bringing it to my notice, I had not checked on this git.
> > I will upload the next version of patches soon corresponding to this
> > git.
> 
> In general please use the media master branch as a base for your patches
> (git://linuxtv.org/media_tree.git master). Or latest branch in my
> git repository, currently it's "for-v4.12/media/next-2" as can be seen
> here: https://git.linuxtv.org/snawrocki/samsung.git
> 
I have submitted the next version(v4) of mfcv10.10 patches based on
git://linuxtv.org/snawrocki/samsung.git for-v4.12/media/next. But I will
keep this in mind next time I submit fresh patches. Thank you for the
information :)

Regards,
Smitha

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-04-11 11:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20170403060045epcas2p215a1d85248b47cc389e20ff877505b09@epcas2p2.samsung.com>
2017-04-03  6:00 ` [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder (fwd) Julia Lawall
2017-04-03  6:17   ` Smitha T Murthy
2017-04-11  9:00     ` Sylwester Nawrocki
2017-04-11  9:23       ` Julia Lawall
2017-04-11  9:51         ` Sylwester Nawrocki
2017-04-11 11:26       ` Smitha T Murthy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox